Bug 82519 – Yarr: if we're not using the output array, don't populate it!

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gavin Barraclough]

Add a new variant of the match method to RegExp that returns a MatchResult, and modify YarrJIT to be able to compile code that doesn't use an output vector.

[Gavin Barraclough]

Created attachment 134393 [details]
Fix

[WebKit Review Bot]

Attachment 134393 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/runtime/RegExp.h:62:  The parameter name "globalData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/runtime/RegExp.h:62:  The parameter name "s" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/runtime/RegExp.cpp:456:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/JavaScriptCore/runtime/RegExp.cpp:477:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/JavaScriptCore/yarr/YarrJIT.cpp:350:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 5 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 134393 [details]
Fix

Attachment 134393 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12154394

[Gavin Barraclough]

Created attachment 134403 [details]
Fix

[Sam Weinig]

Comment on attachment 134403 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=134403&action=review

> Source/JavaScriptCore/runtime/RegExp.cpp:221
>  struct RegExpRepresentation {
> -#if ENABLE(YARR_JIT)
> -    Yarr::YarrCodeBlock m_regExpJITCode;
> -#endif
> -    OwnPtr<Yarr::BytecodePattern> m_regExpBytecode;
>  };

This is now an empty struct.  Is that intentional?

[Build Bot]

Comment on attachment 134403 [details]
Fix

Attachment 134403 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12099073

[Build Bot]

Comment on attachment 134403 [details]
Fix

Attachment 134403 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12153466

[Gavin Barraclough]

Fixed in r112454