Bug 82516 - [chromium] Scheduler should not tell FrameRateController to begin a frame when we dont swap
Summary: [chromium] Scheduler should not tell FrameRateController to begin a frame whe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nat Duca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-28 13:37 PDT by Nat Duca
Modified: 2012-03-28 14:45 PDT (History)
4 users (show)

See Also:


Attachments
Patch (21.39 KB, patch)
2012-03-28 13:38 PDT, Nat Duca
no flags Details | Formatted Diff | Diff
Patch for landing (21.39 KB, patch)
2012-03-28 14:04 PDT, Nat Duca
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nat Duca 2012-03-28 13:37:29 PDT
[chromium] Scheduler should not tell FrameRateController to begin a frame when we dont swap
Comment 1 Nat Duca 2012-03-28 13:38:08 PDT
Created attachment 134384 [details]
Patch
Comment 2 Dana Jansens 2012-03-28 13:48:57 PDT
Comment on attachment 134384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134384&action=review

ooh. interesting bug, nice catch.

> Source/WebKit/chromium/tests/CCSchedulerTest.cpp:429
> +    // We should not have told the frame rate controller that we begun a frame.

nit: began a frame.
Comment 3 James Robinson 2012-03-28 13:56:19 PDT
Comment on attachment 134384 [details]
Patch

R=me
Comment 4 Nat Duca 2012-03-28 14:04:53 PDT
Created attachment 134391 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-03-28 14:45:25 PDT
Comment on attachment 134391 [details]
Patch for landing

Clearing flags on attachment: 134391

Committed r112446: <http://trac.webkit.org/changeset/112446>
Comment 6 WebKit Review Bot 2012-03-28 14:45:29 PDT
All reviewed patches have been landed.  Closing bug.