In file Source/WebKit/chromium/src/android/WebInputEventFactory.cpp, WebInputEventFactory::mouseEvent() doesn't allow caller to specify click count and modifiers. These are useful in specifying events like double click or Ctrl+click, etc.
Created attachment 134635 [details] Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment on attachment 134635 [details] Patch OK. I assume this positively effects tests?
I don't see this method called anywhere, so it shouldn't affect test.
The relevant code has not been upstreamed to Chromium yet, so that is correct. However, our downstream branch doesn't actually know about these parameters, they seem to be specific to Google TV. I'd appreciate it if you could postpone landing this code until we can find a way to synchronize our upstreaming efforts, because this is bound to collide somewhere in the near future (in this case, our local branch would see compile errors following a merge, but that's not something we can ask you to keep in mind). I'll send you a follow up e-mail in the morning.
Do I need to take any action?
No, we'll discuss this via e-mail. Since Eric reviewed your patch I can put it on the commit queue after there's some more clarity :).
Does the Android upstreaming project have documents/diffs anywhere I might see? I'm curious to see how far along ya'll are.
Internally they're on go/upstreamdiff, publicly you could diff the source tarball against ToT (download: http://chromium-browser-source.commondatastorage.googleapis.com/chrome_android_tarball.html).
Oh, I meant the Google TV upstreaming, since it sounded like this bug was Google-TV specific?
Comment on attachment 134635 [details] Patch Putting this on the commit queue.
Comment on attachment 134635 [details] Patch Clearing flags on attachment: 134635 Committed r113048: <http://trac.webkit.org/changeset/113048>
All reviewed patches have been landed. Closing bug.