http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/builds/19311/steps/download-built-product/logs/stdio This shows no error, even though the file is missing. curl -f would spit out an error message: 76$ $ curl -f --output WebKitBuild/release.zip http://build.webkit.org/archives/mac-snowleopard-x86_64-release/112364.zip % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 curl: (22) The requested URL returned error: 404
Created attachment 134389 [details] Patch
Comment on attachment 134389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134389&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:237 > + command = ["curl", "--fail", "--output", WithProperties("WebKitBuild/%(configuration)s.zip"), WithProperties(c["buildbotURL"] + "archives/%(fullPlatform)s-%(architecture)s-%(configuration)s/%(got_revision)s.zip")] On my SnowLeopard man curl says: (HTTP) Fail silently (no output at all) on server errors. This is mostly done to better enable scripts etc to better deal with failed attempts. In normal cases when a HTTP server fails to deliver a document, it returns an HTML document stating so (which often also describes why and more). This flag will prevent curl from outputting that and return error 22. This method is not fail-safe and there are occasions where non-successful response codes will slip through, especially when authentication is involved (response codes 401 and 407). It seems like the opposite of what we want. Or maybe the man page is wrong?
I think the man page is confused: smfr$ curl -O http://www.webkit.org/nonexistant.html % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 214 100 214 0 0 10046 0 --:--:-- --:--:-- --:--:-- 17833 smfr$ echo $? 0 smfr$ curl -O --fail http://www.webkit.org/nonexistant.html % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 curl: (22) The requested URL returned error: 404 smfr$ echo $? 22
Comment on attachment 134389 [details] Patch Okay.
Fixed in r112443. Shown to be working.