Bug 82490 - Split WebKitCSSKeyframeRule into internal and CSSOM types
Summary: Split WebKitCSSKeyframeRule into internal and CSSOM types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 77745
  Show dependency tree / graph
 
Reported: 2012-03-28 11:19 PDT by Antti Koivisto
Modified: 2012-04-11 20:58 PDT (History)
5 users (show)

See Also:

Attachments
patch (29.27 KB, patch)
2012-03-28 13:54 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-03-28 11:19:22 PDT 
WebKitCSSKeyframeRule is a CSSOM type and should not be used internally.
Comment 1 Antti Koivisto 2012-03-28 13:54:08 PDT 
Created attachment 134388 [details]
patch
Comment 2 WebKit Review Bot 2012-03-28 13:57:41 PDT 
Attachment 134388 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSStyleSelector.cpp:1632:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexis Menard (darktears) 2012-03-28 14:21:43 PDT 
Comment on attachment 134388 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134388&action=review

> Source/WebCore/css/WebKitCSSKeyframeRule.cpp:49
> +        

Oops.

> Source/WebCore/css/WebKitCSSKeyframeRule.cpp:-81
> -

Oops.
Comment 4 Antti Koivisto 2012-04-11 20:58:41 PDT 
http://trac.webkit.org/changeset/112516