Bug 82481 - Web Inspector: refactor UI breakpoint listeners.
Summary: Web Inspector: refactor UI breakpoint listeners.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-28 10:43 PDT by Pavel Podivilov
Modified: 2012-04-02 06:57 PDT (History)
11 users (show)

See Also:


Attachments
Patch (18.06 KB, patch)
2012-03-28 10:47 PDT, Pavel Podivilov
no flags Details | Formatted Diff | Diff
Patch (18.12 KB, patch)
2012-03-28 10:55 PDT, Pavel Podivilov
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2012-03-28 10:43:26 PDT
Web Inspector: refactor UI breakpoint listeners.

Breakpoint-added and breakpoint-removed events are now dispatched on UISourceCode. So handlers that manage SourceFrame's breakpoint decorations could be moved from ScriptsPanel to SourceFrame.
Comment 1 Pavel Podivilov 2012-03-28 10:47:34 PDT
Created attachment 134335 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-28 10:51:33 PDT
Attachment 134335 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1
LayoutTests/ChangeLog:1:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Pavel Podivilov 2012-03-28 10:55:25 PDT
Created attachment 134337 [details]
Patch
Comment 4 Vsevolod Vlasov 2012-03-28 11:02:48 PDT
Comment on attachment 134337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134337&action=review

> Source/WebCore/inspector/front-end/ScriptsPanel.js:257
> +        this._addBreakpointListeners(uiSourceCode);

This method adds breakpoint listeners twice now, I don't think this is what you meant to do here.

> Source/WebCore/inspector/front-end/SourceFrame.js:-58
> -    Loaded: "loaded"

Could you please mention removing of this event in the ChangeLog?
Comment 5 Pavel Podivilov 2012-04-02 06:57:36 PDT
Committed r112875: <http://trac.webkit.org/changeset/112875>