Bug 82475 - Web Inspector: Add context menu for snippets control.
Summary: Web Inspector: Add context menu for snippets control.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-28 09:58 PDT by Vsevolod Vlasov
Modified: 2012-03-28 11:14 PDT (History)
10 users (show)

See Also:

Attachments
Patch (7.56 KB, patch)
2012-03-28 10:05 PDT, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch (7.74 KB, patch)
2012-03-28 10:08 PDT, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch (7.66 KB, patch)
2012-03-28 10:10 PDT, Vsevolod Vlasov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-03-28 09:58:23 PDT 
This is a preliminary implementation of snippets control.
We might want to add a more visual one before taking snippets out of experiments.
Comment 1 Vsevolod Vlasov 2012-03-28 10:05:03 PDT 
Created attachment 134322 [details]
Patch
Comment 2 Pavel Feldman 2012-03-28 10:08:14 PDT 
Comment on attachment 134322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134322&action=review

> Source/WebCore/ChangeLog:8
> +        * English.lproj/localizedStrings.js:

Please explain what is happening in the change.

> Source/WebCore/inspector/front-end/ScriptsNavigator.js:296
> +            

Blank line.

> Source/WebCore/inspector/front-end/ScriptsNavigator.js:304
> +        event.preventDefault();

ContextMenu.show consumes event for you.
Comment 3 Vsevolod Vlasov 2012-03-28 10:08:52 PDT 
Created attachment 134323 [details]
Patch
Comment 4 Vsevolod Vlasov 2012-03-28 10:10:38 PDT 
Created attachment 134324 [details]
Patch
Comment 5 Pavel Feldman 2012-03-28 10:16:50 PDT 
Comment on attachment 134324 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134324&action=review

> Source/WebCore/ChangeLog:9
> +        We might want to add a more visual one before taking snippets out of experiments.

a more discoverable one?
Comment 6 Vsevolod Vlasov 2012-03-28 11:14:05 PDT 
Committed r112414: <http://trac.webkit.org/changeset/112414>