RESOLVED FIXED Bug 82457
[BlackBerry] Plumb through GraphicsLayer::contentsOpaque() to the LayerTiler 
https://bugs.webkit.org/show_bug.cgi?id=82457
Summary [BlackBerry] Plumb through GraphicsLayer::contentsOpaque() to the LayerTiler
Arvid Nilsson
Reported 2012-03-28 06:07:13 PDT
The LayerTiler already knows not to turn on GL_BLEND for opaque layers. However, it only ever sets the opaque flag for image layers and color layers, never for content layers. This was no big deal, because content layers are never opaque, except for the root layer, which we always drew using the BlackBerry::WebKit::BackingStore anyway. Now, we're going to start using RenderLayerBacking::m_usingTiledCacheLayer = true on the root layer in some situations to make the root layer draw using the LayerRenderer instead of the BackingStore (specifically, in situations where the BackingStore is inactive). So make sure we plumb through the GraphicsLayer::contentsOpaque() flag all the way to LayerTiler and on to Texture.
Attachments
Patch (12.71 KB, patch)
2012-03-28 06:18 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Arvid Nilsson
Comment 1 2012-03-28 06:09:55 PDT
No new tests, this stuff is currently not testable in the BlackBerry DRT infrastructure.
Arvid Nilsson
Comment 2 2012-03-28 06:18:46 PDT
Created attachment 134281 [details] Patch
Rob Buis
Comment 3 2012-03-28 08:16:00 PDT
Comment on attachment 134281 [details] Patch Looks fine.
WebKit Review Bot
Comment 4 2012-03-28 09:03:44 PDT
Comment on attachment 134281 [details] Patch Clearing flags on attachment: 134281 Committed r112407: <http://trac.webkit.org/changeset/112407>
WebKit Review Bot
Comment 5 2012-03-28 09:03:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.