RESOLVED FIXED Bug 82451
Web Inspector: use maxJSObjectId provided by back-end. 
https://bugs.webkit.org/show_bug.cgi?id=82451
Summary Web Inspector: use maxJSObjectId provided by back-end.
Ilya Tikhonovsky
Reported 2012-03-28 04:59:26 PDT
Summary view can filter objects in snapshot. It uses maxJSObjectId for this. There is no such field in the profile header at the moment but I've landed a patch in downstream.
Attachments
Patch (7.76 KB, patch)
2012-04-03 01:06 PDT, Ilya Tikhonovsky 		yurys: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-04-03 01:06:13 PDT
Created attachment 135288 [details] Patch
Early Warning System Bot
Comment 2 2012-04-03 01:12:17 PDT
Comment on attachment 135288 [details] Patch Attachment 135288 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12312955
Gyuyoung Kim
Comment 3 2012-04-03 01:12:49 PDT
Comment on attachment 135288 [details] Patch Attachment 135288 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12322009
Yury Semikhatsky
Comment 4 2012-04-03 01:13:37 PDT
Comment on attachment 135288 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135288&action=review > Source/WebCore/inspector/front-end/DetailedHeapshotView.js:279 > + if (this._filterProfileIndex !== -1) { Could you use profileIndex here as well(just for clarity)?
Early Warning System Bot
Comment 5 2012-04-03 01:15:37 PDT
Comment on attachment 135288 [details] Patch Attachment 135288 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12322010
Philippe Normand
Comment 6 2012-04-03 01:18:27 PDT
Comment on attachment 135288 [details] Patch Attachment 135288 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12320023
WebKit Review Bot
Comment 7 2012-04-03 01:27:36 PDT
Comment on attachment 135288 [details] Patch Attachment 135288 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12321013
Build Bot
Comment 8 2012-04-03 01:28:34 PDT
Comment on attachment 135288 [details] Patch Attachment 135288 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12321014
Ilya Tikhonovsky
Comment 9 2012-04-03 01:28:53 PDT
Committed r112994: <http://trac.webkit.org/changeset/112994>
Ilya Tikhonovsky
Comment 10 2012-04-10 04:34:25 PDT
Committed r113708: <http://trac.webkit.org/changeset/113708>
Note You need to log in before you can comment on or make changes to this bug.