Bug 82450 - [chromium] MediaStream API (JSEP): Introducing WebPeerConnection00Handler
Summary: [chromium] MediaStream API (JSEP): Introducing WebPeerConnection00Handler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 80589
  Show dependency treegraph
 
Reported: 2012-03-28 04:53 PDT by Tommy Widenflycht
Modified: 2012-03-29 01:34 PDT (History)
6 users (show)

See Also:


Attachments
Patch (33.56 KB, patch)
2012-03-28 05:31 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-03-28 04:53:30 PDT
Last patch to enable the PeerConnection00 functionality in Chromium introduces WebPeerConnection00Handler and WebPeerConnection00HandlerClient, together with the necessary plumbing.
Comment 1 Tommy Widenflycht 2012-03-28 05:31:54 PDT
Created attachment 134272 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-28 05:35:33 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2012-03-28 10:42:18 PDT
Comment on attachment 134272 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134272&action=review

I'm marking this cq+ to avoid the over night round-trip, but please post a followup patch that adds the comment below.  Many thanks!

> Source/WebKit/chromium/bridge/PeerConnection00HandlerInternal.cpp:60
> +    m_webHandler = adoptPtr(WebKit::webKitPlatformSupport()->createPeerConnection00Handler(this));

Can this fail?

> Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:413
>      virtual WebPeerConnectionHandler* createPeerConnectionHandler(WebPeerConnectionHandlerClient*) { return 0; }
> +    virtual WebPeerConnection00Handler* createPeerConnection00Handler(WebPeerConnection00HandlerClient*) { return 0; }

Can you add a comment explaining the difference between these two?  This probably looks confusing for folks who haven't been following this discussion in detail.
Comment 4 WebKit Review Bot 2012-03-28 11:44:24 PDT
Comment on attachment 134272 [details]
Patch

Clearing flags on attachment: 134272

Committed r112421: <http://trac.webkit.org/changeset/112421>
Comment 5 WebKit Review Bot 2012-03-28 11:44:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Tommy Widenflycht 2012-03-29 01:34:17 PDT
Comment on attachment 134272 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134272&action=review

>> Source/WebKit/chromium/bridge/PeerConnection00HandlerInternal.cpp:60
>> +    m_webHandler = adoptPtr(WebKit::webKitPlatformSupport()->createPeerConnection00Handler(this));
> 
> Can this fail?

Yes, it can if something erroneous happens in the Chromium code for example.

There is a comment regarding this in WebKitPlatformSupport.h.

>> Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:413
>> +    virtual WebPeerConnection00Handler* createPeerConnection00Handler(WebPeerConnection00HandlerClient*) { return 0; }
> 
> Can you add a comment explaining the difference between these two?  This probably looks confusing for folks who haven't been following this discussion in detail.

Will do.