Bug 82444 - [BlackBerry] Clean up ImageBufferData
Summary: [BlackBerry] Clean up ImageBufferData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-28 03:36 PDT by Robin Cao
Modified: 2012-03-29 04:57 PDT (History)
7 users (show)

See Also:

Attachments
patch (1.76 KB, patch)
2012-03-28 20:37 PDT, Robin Cao 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Cao 2012-03-28 03:36:50 PDT 
We need to clean up WebCore/platform/graphics/blackberry/skia/ImageBufferDataSkia.h.

m_buffer is not used and should be removed.
RefPtr<LayerWebKitThread> m_platformLayer; -->> RefPtr<CanvasLayerWebKitThread> m_platformLayer;
Comment 1 Rob Buis 2012-03-28 04:13:04 PDT 
Hi Robin,

Make sure to coordinate this with Filip please.
Cheers,

Rob.
Comment 2 Filip Spacek 2012-03-28 13:57:29 PDT 
That's a good cleanup Robin. I'm all for it.
Comment 3 Robin Cao 2012-03-28 20:37:15 PDT 
Created attachment 134488 [details]
patch
Comment 4 Rob Buis 2012-03-29 04:13:54 PDT 
Comment on attachment 134488 [details]
patch

Ok.
Comment 5 WebKit Review Bot 2012-03-29 04:57:12 PDT 
Comment on attachment 134488 [details]
patch

Clearing flags on attachment: 134488

Committed r112519: <http://trac.webkit.org/changeset/112519>
Comment 6 WebKit Review Bot 2012-03-29 04:57:16 PDT 
All reviewed patches have been landed.  Closing bug.