Bug 82442 – Consider removal of removes jsNull()/v8::Null() from JSInternalsCustom.cpp/V8InternalsCustom.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Vineet Chaudhary (vineetc)]

This has comeup with https://bugs.webkit.org/show_bug.cgi?id=82319#c3
We would like to know if it an expected behaviour for Internals.idl to return null when the vector is empty?

[Vineet Chaudhary (vineetc)]

Created attachment 134250 [details]
proposed patch

Attacjing proposed patch. This will test if any test case failures.
Please us know if any objections/suggestions. Thanks.

[Kentaro Hara]

eric.carlson: Would you take a look at the change? (See also https://bugs.webkit.org/show_bug.cgi?id=82319) The behavior when the Vector is empty is not spec-ed, and we guess that we can remove the code that returns null when the Vector is empty.

[Kentaro Hara]

(In reply to comment #1)
> Attacjing proposed patch. This will test if any test case failures.

If no existing tests are affected, maybe we want to add test cases for this.

[Vineet Chaudhary (vineetc)]

(In reply to comment #3)
> (In reply to comment #1)
> > Attaching proposed patch. This will test if any test case failures.
> 
> If no existing tests are affected, maybe we want to add test cases for this.

Currently there is already a test case http://trac.webkit.org/browser/trunk/LayoutTests/fast/harness/user-preferred-language.html?rev=105315#L20  which checks for empty vector but this wont fail even if we remove 

if (languages.isEmpty())
  return jsNull(); 

Because all the platform have the implementation for platformLanguages().

[Eric Carlson]

(In reply to comment #2)
> eric.carlson: Would you take a look at the change? (See also https://bugs.webkit.org/show_bug.cgi?id=82319) The behavior when the Vector is empty is not spec-ed, and we guess that we can remove the code that returns null when the Vector is empty.

This seems like a reasonable change to me.

[Vineet Chaudhary (vineetc)]

(In reply to comment #5)
> (In reply to comment #2)
> > eric.carlson: Would you take a look at the change? (See also https://bugs.webkit.org/show_bug.cgi?id=82319) The behavior when the Vector is empty is not spec-ed, and we guess that we can remove the code that returns null when the Vector is empty.
> 
> This seems like a reasonable change to me.

As per comment #4 the test case covers empty vector case. Do I need to add more coverage for the test?

[Kentaro Hara]

Comment on attachment 134250 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134250&action=review

> Source/WebCore/ChangeLog:9
> +        No new tests. LayoutTests/fast/harness/user-preferred-language.html should pass
> +        even after these changes.

OK, it would be hard to add a new test case for this change.

[WebKit Review Bot]

Comment on attachment 134250 [details]
proposed patch

Clearing flags on attachment: 134250

Committed r112502: <http://trac.webkit.org/changeset/112502>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.