RESOLVED FIXED 82420
[BlackBerry] Use WebCore::PlatformMouseEvent::globalPosition() instead of WebCore::PlatformMouseEvent::globalPos() in WebPage.cpp 
https://bugs.webkit.org/show_bug.cgi?id=82420
Summary [BlackBerry] Use WebCore::PlatformMouseEvent::globalPosition() instead of Web...
Leo Yang
Reported 2012-03-27 20:03:01 PDT
In PlatformMouseEvent.h the blackberry porting added globalPos() (but not upstreamed yet) for PlatformMouseEvent, but this method is same as globalPosition() that is available for every porting. We should use globalPosition().
Attachments
Patch (2.58 KB, patch)
2012-03-27 20:06 PDT, Leo Yang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Leo Yang
Comment 1 2012-03-27 20:06:35 PDT
Created attachment 134208 [details] Patch
Rob Buis
Comment 2 2012-03-28 04:09:49 PDT
Comment on attachment 134208 [details] Patch LGTM. Can we remove globalPos()?
Leo Yang
Comment 3 2012-03-28 05:09:30 PDT
(In reply to comment #2) > (From update of attachment 134208 [details]) > LGTM. Can we remove globalPos()? Thanks. When I cherry-pick I'll remove it internally.
WebKit Review Bot
Comment 4 2012-03-28 05:31:38 PDT
Comment on attachment 134208 [details] Patch Clearing flags on attachment: 134208 Committed r112385: <http://trac.webkit.org/changeset/112385>
WebKit Review Bot
Comment 5 2012-03-28 05:31:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.