Bug 82407 - [chromium] Merge ChromiumDataObject and DataTransferItemListChromium.
Summary: [chromium] Merge ChromiumDataObject and DataTransferItemListChromium.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Cheng
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-27 18:27 PDT by Daniel Cheng
Modified: 2012-03-28 15:03 PDT (History)
0 users

See Also:

Attachments
Patch (57.57 KB, patch)
2012-03-27 18:31 PDT, Daniel Cheng 		no flags Details | Formatted Diff | Diff
Patch (57.65 KB, patch)
2012-03-28 11:37 PDT, Daniel Cheng 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Cheng 2012-03-27 18:27:27 PDT 
[chromium] Merge ChromiumDataObject and DataTransferItemListChromium.
Comment 1 Daniel Cheng 2012-03-27 18:31:50 PDT 
Created attachment 134191 [details]
Patch
Comment 2 Tony Chang 2012-03-28 09:47:44 PDT 
Comment on attachment 134191 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134191&action=review

Looks like your patch needs to be rebased.  Please make sure to have a green ews run on all the bots before landing.

> Source/WebCore/ChangeLog:14
> +        * platform/chromium/ChromiumDataObject.cpp:

Please mention here that this is replacing DataTransferItemListChromium.

> Source/WebCore/platform/chromium/ChromiumDataObject.h:59
> +    // DataTransferItemList support.
> +    size_t length() const;

Should ChromiumDataObject implement DataTransferItemList?

> Source/WebCore/platform/chromium/ChromiumDataObjectItem.h:49
> +class ChromiumDataObjectItem : public RefCounted<ChromiumDataObjectItem> {

Should ChromiumDataObjectItem implement DataTransferItem?
Comment 3 Daniel Cheng 2012-03-28 11:34:10 PDT 
(In reply to comment #2)
> (From update of attachment 134191 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134191&action=review
> 
> Looks like your patch needs to be rebased.  Please make sure to have a green ews run on all the bots before landing.
> 
> > Source/WebCore/ChangeLog:14
> > +        * platform/chromium/ChromiumDataObject.cpp:
> 
> Please mention here that this is replacing DataTransferItemListChromium.
> 

Done.

> > Source/WebCore/platform/chromium/ChromiumDataObject.h:59
> > +    // DataTransferItemList support.
> > +    size_t length() const;
> 
> Should ChromiumDataObject implement DataTransferItemList?
> 
> > Source/WebCore/platform/chromium/ChromiumDataObjectItem.h:49
> > +class ChromiumDataObjectItem : public RefCounted<ChromiumDataObjectItem> {
> 
> Should ChromiumDataObjectItem implement DataTransferItem?

We don't implement these interfaces because the signatures of some functions are a little different, plus we avoid virtual dispatch.
Comment 4 Daniel Cheng 2012-03-28 11:37:05 PDT 
Created attachment 134352 [details]
Patch
Comment 5 Daniel Cheng 2012-03-28 15:03:51 PDT 
Committed r112448: <http://trac.webkit.org/changeset/112448>