Bug 82403 - Add missing methods and operators to FractionalLayoutUnit
Summary: Add missing methods and operators to FractionalLayoutUnit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2012-03-27 17:37 PDT by Emil A Eklund
Modified: 2012-04-13 11:13 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.21 KB, patch)
2012-03-28 08:45 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Patch (5.03 KB, patch)
2012-03-28 11:50 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Patch (4.71 KB, patch)
2012-04-05 18:16 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Patch (3.78 KB, patch)
2012-04-09 10:50 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-03-27 17:37:26 PDT 
Add missing operators and constructors to FractionalLayoutUnit.
Comment 1 Emil A Eklund 2012-03-28 08:45:54 PDT 
Created attachment 134304 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-28 08:52:51 PDT 
Attachment 134304 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/FractionalLayoutUnit.h:82:  wtf_ceil is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2012-03-28 09:07:38 PDT 
Comment on attachment 134304 [details]
Patch

Attachment 134304 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12153242
Comment 4 Build Bot 2012-03-28 09:09:33 PDT 
Comment on attachment 134304 [details]
Patch

Attachment 134304 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12153246
Comment 5 Early Warning System Bot 2012-03-28 09:13:49 PDT 
Comment on attachment 134304 [details]
Patch

Attachment 134304 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12159101
Comment 6 Emil A Eklund 2012-03-28 11:50:46 PDT 
Created attachment 134356 [details]
Patch
Comment 7 WebKit Review Bot 2012-03-28 11:56:59 PDT 
Attachment 134356 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/FractionalLayoutUnit.h:81:  wtf_ceil is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Philippe Normand 2012-03-28 12:11:18 PDT 
Comment on attachment 134356 [details]
Patch

Attachment 134356 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12152338
Comment 9 Build Bot 2012-03-28 12:37:58 PDT 
Comment on attachment 134356 [details]
Patch

Attachment 134356 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12152353
Comment 10 Early Warning System Bot 2012-03-28 13:18:29 PDT 
Comment on attachment 134356 [details]
Patch

Attachment 134356 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12153413
Comment 11 Emil A Eklund 2012-03-28 13:22:08 PDT 
Argh, sorry about all the spam, please ignore this bug for now.
Comment 12 Early Warning System Bot 2012-03-28 13:35:48 PDT 
Comment on attachment 134356 [details]
Patch

Attachment 134356 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12156290
Comment 13 WebKit Review Bot 2012-03-28 13:48:46 PDT 
Comment on attachment 134356 [details]
Patch

Attachment 134356 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12152387
Comment 14 Emil A Eklund 2012-04-05 18:16:10 PDT 
Created attachment 135957 [details]
Patch
Comment 15 WebKit Review Bot 2012-04-05 18:20:17 PDT 
Attachment 135957 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/FractionalLayoutUnit.h:81:  wtf_ceil is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 16 Early Warning System Bot 2012-04-05 19:57:24 PDT 
Comment on attachment 135957 [details]
Patch

Attachment 135957 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12337629
Comment 17 Early Warning System Bot 2012-04-05 20:09:57 PDT 
Comment on attachment 135957 [details]
Patch

Attachment 135957 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12336709
Comment 18 Eric Seidel (no email) 2012-04-06 10:19:16 PDT 
Unhappy ewses.
Comment 19 Build Bot 2012-04-06 19:08:11 PDT 
Comment on attachment 135957 [details]
Patch

Attachment 135957 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12343011
Comment 20 Emil A Eklund 2012-04-09 10:50:08 PDT 
Created attachment 136265 [details]
Patch
Comment 21 WebKit Review Bot 2012-04-09 10:53:24 PDT 
Attachment 136265 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/FractionalLayoutUnit.h:81:  wtf_ceil is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 22 Emil A Eklund 2012-04-09 12:01:05 PDT 
The style ews failure is expected (wtf_ceil) but the others seem happy now at least.
Comment 23 Emil A Eklund 2012-04-09 19:03:14 PDT 
Can haz review?
Comment 24 Eric Seidel (no email) 2012-04-09 19:34:07 PDT 
Comment on attachment 136265 [details]
Patch

OK.
Comment 25 WebKit Review Bot 2012-04-10 10:11:30 PDT 
Comment on attachment 136265 [details]
Patch

Clearing flags on attachment: 136265

Committed r113730: <http://trac.webkit.org/changeset/113730>
Comment 26 WebKit Review Bot 2012-04-10 10:11:36 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 27 Lucas Forschler 2012-04-13 11:03:06 PDT 
This check in causes a 20% decrease in performance for the Mac Lion dromeo test
http://webkit-perf.appspot.com/graph.html#tests=[[33030,2001,32196]]&sel=none&displayrange=7&datatype=running
Comment 28 Levi Weintraub 2012-04-13 11:05:26 PDT 
(In reply to comment #27)
> This check in causes a 20% decrease in performance for the Mac Lion dromeo test
> http://webkit-perf.appspot.com/graph.html#tests=[[33030,2001,32196]]&sel=none&displayrange=7&datatype=running

I don't think this is the cause of that regression... None of this code is in use yet.
Comment 29 Lucas Forschler 2012-04-13 11:07:41 PDT 
Ah, the test results are not atomic.  The regression happened somewhere between 113608 and 113730.
Comment 30 Levi Weintraub 2012-04-13 11:13:33 PDT 
(In reply to comment #29)
> Ah, the test results are not atomic.  The regression happened somewhere between 113608 and 113730.

That'd explain it :) Here's a handy link: http://trac.webkit.org/log/?action=stop_on_copy&mode=stop_on_copy&rev=113730&stop_rev=113608&limit=200