Bug 82403 – Add missing methods and operators to FractionalLayoutUnit

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Emil A Eklund]

Add missing operators and constructors to FractionalLayoutUnit.

[Emil A Eklund]

Created attachment 134304 [details]
Patch

[WebKit Review Bot]

Attachment 134304 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/FractionalLayoutUnit.h:82:  wtf_ceil is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 134304 [details]
Patch

Attachment 134304 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12153242

[Build Bot]

Comment on attachment 134304 [details]
Patch

Attachment 134304 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12153246

[Early Warning System Bot]

Comment on attachment 134304 [details]
Patch

Attachment 134304 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12159101

[Emil A Eklund]

Created attachment 134356 [details]
Patch

[WebKit Review Bot]

Attachment 134356 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/FractionalLayoutUnit.h:81:  wtf_ceil is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Philippe Normand]

Comment on attachment 134356 [details]
Patch

Attachment 134356 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12152338

[Build Bot]

Comment on attachment 134356 [details]
Patch

Attachment 134356 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12152353

[Early Warning System Bot]

Comment on attachment 134356 [details]
Patch

Attachment 134356 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12153413

[Emil A Eklund]

Argh, sorry about all the spam, please ignore this bug for now.

[Early Warning System Bot]

Comment on attachment 134356 [details]
Patch

Attachment 134356 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12156290

[WebKit Review Bot]

Comment on attachment 134356 [details]
Patch

Attachment 134356 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12152387

[Emil A Eklund]

Created attachment 135957 [details]
Patch

[WebKit Review Bot]

Attachment 135957 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/FractionalLayoutUnit.h:81:  wtf_ceil is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 135957 [details]
Patch

Attachment 135957 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12337629

[Early Warning System Bot]

Comment on attachment 135957 [details]
Patch

Attachment 135957 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12336709

[Eric Seidel (no email)]

Unhappy ewses.

[Build Bot]

Comment on attachment 135957 [details]
Patch

Attachment 135957 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12343011

[Emil A Eklund]

Created attachment 136265 [details]
Patch

[WebKit Review Bot]

Attachment 136265 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/FractionalLayoutUnit.h:81:  wtf_ceil is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Emil A Eklund]

The style ews failure is expected (wtf_ceil) but the others seem happy now at least.

[Emil A Eklund]

Can haz review?

[Eric Seidel (no email)]

Comment on attachment 136265 [details]
Patch

OK.

[WebKit Review Bot]

Comment on attachment 136265 [details]
Patch

Clearing flags on attachment: 136265

Committed r113730: <http://trac.webkit.org/changeset/113730>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Lucas Forschler]

This check in causes a 20% decrease in performance for the Mac Lion dromeo test
http://webkit-perf.appspot.com/graph.html#tests=[[33030,2001,32196]]&sel=none&displayrange=7&datatype=running

[Levi Weintraub]

(In reply to comment #27)
> This check in causes a 20% decrease in performance for the Mac Lion dromeo test
> http://webkit-perf.appspot.com/graph.html#tests=[[33030,2001,32196]]&sel=none&displayrange=7&datatype=running

I don't think this is the cause of that regression... None of this code is in use yet.

[Lucas Forschler]

Ah, the test results are not atomic.  The regression happened somewhere between 113608 and 113730.

[Levi Weintraub]

(In reply to comment #29)
> Ah, the test results are not atomic.  The regression happened somewhere between 113608 and 113730.

That'd explain it :) Here's a handy link: http://trac.webkit.org/log/?action=stop_on_copy&mode=stop_on_copy&rev=113730&stop_rev=113608&limit=200