Bug 82397 - Simplify CSSPropertyBorderSpacing parsing.
Summary: Simplify CSSPropertyBorderSpacing parsing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexis Menard (darktears)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-27 16:46 PDT by Alexis Menard (darktears)
Modified: 2012-03-27 17:27 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.19 KB, patch)
2012-03-27 16:48 PDT, Alexis Menard (darktears) 		no flags Details | Formatted Diff | Diff
Patch (2.18 KB, patch)
2012-03-27 17:01 PDT, Alexis Menard (darktears) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2012-03-27 16:46:45 PDT 
Share code with CSSPropertyLonghand when parsing CSSPropertyBorderSpacing.
Comment 1 Alexis Menard (darktears) 2012-03-27 16:48:56 PDT 
Created attachment 134167 [details]
Patch
Comment 2 Benjamin Poulain 2012-03-27 16:52:09 PDT 
Comment on attachment 134167 [details]
Patch

I don't get it, why not pass the property directly?:
    if (!parseValue(CSSPropertyWebkitBorderHorizontalSpacing, important))
Comment 3 Alexis Menard (darktears) 2012-03-27 16:54:07 PDT 
(In reply to comment #2)
> (From update of attachment 134167 [details])
> I don't get it, why not pass the property directly?:
>     if (!parseValue(CSSPropertyWebkitBorderHorizontalSpacing, important))

Could be. Let me update the bug name then.
Comment 4 Alexis Menard (darktears) 2012-03-27 17:01:39 PDT 
Created attachment 134172 [details]
Patch
Comment 5 Benjamin Poulain 2012-03-27 17:05:36 PDT 
Comment on attachment 134172 [details]
Patch

Looks good. The CSSPropertyID looks much better than properties[x]
Comment 6 WebKit Review Bot 2012-03-27 17:27:44 PDT 
Comment on attachment 134172 [details]
Patch

Clearing flags on attachment: 134172

Committed r112341: <http://trac.webkit.org/changeset/112341>
Comment 7 WebKit Review Bot 2012-03-27 17:27:57 PDT 
All reviewed patches have been landed.  Closing bug.