Bug 82388 - kill-old-processes doesn't do anything on linux
Summary: kill-old-processes doesn't do anything on linux
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-27 15:34 PDT by Ryosuke Niwa
Modified: 2012-03-28 01:27 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.19 KB, patch)
2012-03-27 15:36 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
proposed fix for Qt bots (1.55 KB, patch)
2012-03-27 22:46 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
proposed fix for Qt bots (1.55 KB, patch)
2012-03-27 22:48 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
proposed fix for Qt bots (1.79 KB, patch)
2012-03-28 00:00 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
better fix for Qt bots (1.79 KB, patch)
2012-03-28 00:09 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-03-27 15:34:11 PDT
kill-old-processes doesn't do anything on linux
Comment 1 Ryosuke Niwa 2012-03-27 15:36:04 PDT
Created attachment 134149 [details]
Patch
Comment 2 Ryosuke Niwa 2012-03-27 15:42:40 PDT
Ossy:

Tony told me that this may cause problems for Qt bots since you guys run multiple builders simultaneously on the same machine. Is that still the case?
Comment 3 Csaba Osztrogonác 2012-03-27 22:22:34 PDT
(In reply to comment #2)
> Ossy:
> 
> Tony told me that this may cause problems for Qt bots since you guys run multiple builders simultaneously on the same machine. Is that still the case?

Yes, we still run multiple builders on the same machine. Additionally sometimes we try something on the bots. So this patch would be overkiller for our bots. :(
Comment 4 Csaba Osztrogonác 2012-03-27 22:46:06 PDT
Created attachment 134220 [details]
proposed fix for Qt bots

We don't need kill old processes for the Qt bots,
so the simplest solution is that we don't run it. :)

This patch should be landed and master should be 
reconfigured before the other patch landed from this bug.
Comment 5 Csaba Osztrogonác 2012-03-27 22:46:34 PDT
Comment on attachment 134220 [details]
proposed fix for Qt bots

ooops, typo
Comment 6 Csaba Osztrogonác 2012-03-27 22:48:09 PDT
Created attachment 134221 [details]
proposed fix for Qt bots

s/==/!=/g - done ;)
Comment 7 Csaba Osztrogonác 2012-03-27 23:43:41 PDT
Comment on attachment 134221 [details]
proposed fix for Qt bots

Clearing flags on attachment: 134221

Committed r112367: <http://trac.webkit.org/changeset/112367>
Comment 8 Csaba Osztrogonác 2012-03-28 00:00:25 PDT
Created attachment 134224 [details]
proposed fix for Qt bots

Unfortunately the previous one didn't work,
because platform were qt-4.8, qt-5.0-wk1, ... here
Comment 9 Csaba Osztrogonác 2012-03-28 00:09:00 PDT
Created attachment 134225 [details]
better fix for Qt bots
Comment 10 Csaba Osztrogonác 2012-03-28 01:16:37 PDT
Comment on attachment 134225 [details]
better fix for Qt bots

Clearing flags on attachment: 134225

Committed r112371: <http://trac.webkit.org/changeset/112371>
Comment 11 Csaba Osztrogonác 2012-03-28 01:20:52 PDT
(In reply to comment #10)
> (From update of attachment 134225 [details])
> Clearing flags on attachment: 134225
> 
> Committed r112371: <http://trac.webkit.org/changeset/112371>

Qt bots don't run kill-old-processes anymore, so it's safe to land the original patch now.
Comment 12 WebKit Review Bot 2012-03-28 01:26:55 PDT
Comment on attachment 134149 [details]
Patch

Clearing flags on attachment: 134149

Committed r112373: <http://trac.webkit.org/changeset/112373>
Comment 13 WebKit Review Bot 2012-03-28 01:27:00 PDT
All reviewed patches have been landed.  Closing bug.