Bug 82387 - Plug-ins using the Core Animation drawing model should work when hosting the layer tree in the window server
Summary: Plug-ins using the Core Animation drawing model should work when hosting the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-27 15:19 PDT by Anders Carlsson
Modified: 2012-03-27 17:17 PDT (History)
5 users (show)

See Also:


Attachments
Patch (26.67 KB, patch)
2012-03-27 15:34 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (26.76 KB, patch)
2012-03-27 15:47 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (26.67 KB, patch)
2012-03-27 15:55 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-03-27 15:19:56 PDT
Plug-ins using the Core Animation drawing model should work when hosting the layer tree in the window server
Comment 1 Anders Carlsson 2012-03-27 15:34:09 PDT
Created attachment 134148 [details]
Patch
Comment 2 Early Warning System Bot 2012-03-27 15:43:42 PDT
Comment on attachment 134148 [details]
Patch

Attachment 134148 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12147744
Comment 3 Gustavo Noronha (kov) 2012-03-27 15:44:24 PDT
Comment on attachment 134148 [details]
Patch

Attachment 134148 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12142750
Comment 4 Sam Weinig 2012-03-27 15:46:30 PDT
Comment on attachment 134148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134148&action=review

> Source/WebKit2/PluginProcess/PluginControllerProxy.messages.in:103
> +    # Sent when the containing window's layer hosting mode changes
> +    SetLayerHostingMode(uint32_t layerHostingMode)

Do we want to call this LayerHostingModeChanged to match the message above?

> Source/WebKit2/WebProcess/Plugins/Plugin.h:29
> +#include "LayerHostingContext.h"

Is this header included on all platforms? Or should it be in an #ifdef?
Comment 5 Anders Carlsson 2012-03-27 15:47:39 PDT
Created attachment 134152 [details]
Patch
Comment 6 Gustavo Noronha (kov) 2012-03-27 15:53:30 PDT
Comment on attachment 134152 [details]
Patch

Attachment 134152 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12140789
Comment 7 Anders Carlsson 2012-03-27 15:55:40 PDT
(In reply to comment #4)
> (From update of attachment 134148 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134148&action=review
> 
> > Source/WebKit2/PluginProcess/PluginControllerProxy.messages.in:103
> > +    # Sent when the containing window's layer hosting mode changes
> > +    SetLayerHostingMode(uint32_t layerHostingMode)
> 
> Do we want to call this LayerHostingModeChanged to match the message above?
> 

Nah, it's really a setter.

> > Source/WebKit2/WebProcess/Plugins/Plugin.h:29
> > +#include "LayerHostingContext.h"
> 
> Is this header included on all platforms? Or should it be in an #ifdef?

I'll add #ifdefs.
Comment 8 Anders Carlsson 2012-03-27 15:55:50 PDT
Created attachment 134154 [details]
Patch
Comment 9 Anders Carlsson 2012-03-27 17:17:09 PDT
Committed r112338: <http://trac.webkit.org/changeset/112338>