Bug 82362 - Web Inspector: Provide private -[DOMNode inspect]
Summary: Web Inspector: Provide private -[DOMNode inspect]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-27 11:52 PDT by Joseph Pecoraro
Modified: 2012-03-27 19:49 PDT (History)
12 users (show)

See Also:

Attachments
[PATCH] Proposed Patch (3.07 KB, patch)
2012-03-27 11:55 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Patch (3.07 KB, patch)
2012-03-27 11:57 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2012-03-27 11:52:41 PDT 
Add -[DOMNode inspect] as a way to open a particular node in the inspector.
Comment 1 Joseph Pecoraro 2012-03-27 11:55:42 PDT 
Created attachment 134111 [details]
[PATCH] Proposed Patch
Comment 2 Joseph Pecoraro 2012-03-27 11:56:11 PDT 
Comment on attachment 134111 [details]
[PATCH] Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134111&action=review

> Source/WebCore/bindings/objc/DOM.mm:49
> +#import "Page.h"
> +#import "InspectorController.h"

Oops, ordering.
Comment 3 Joseph Pecoraro 2012-03-27 11:57:17 PDT 
Created attachment 134112 [details]
[PATCH] Proposed Patch
Comment 4 WebKit Review Bot 2012-03-27 13:08:23 PDT 
Comment on attachment 134112 [details]
[PATCH] Proposed Patch

Clearing flags on attachment: 134112

Committed r112305: <http://trac.webkit.org/changeset/112305>
Comment 5 WebKit Review Bot 2012-03-27 13:08:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Sam Weinig 2012-03-27 15:53:33 PDT 
Can this be done using IDL?
Comment 7 Joseph Pecoraro 2012-03-27 16:04:20 PDT 
(In reply to comment #6)
> Can this be done using IDL?

Probably. Is there a way to specify that this IDL is for ObjC only, and not
meant to actually add something to the JS* interfaces? I did a brief search
through IDL and didn't find a keyword for this, but I'm pretty new to IDL.
If so, this could be added to Node.idl and we could implement Node::inspect.
Comment 8 Timothy Hatcher 2012-03-27 16:10:12 PDT 
You can use #ifdefs to make it ObjC only.
Comment 9 Joseph Pecoraro 2012-03-27 16:11:10 PDT 
Ahh, I think I found it. There is a bunch of this in other IDL files:

  #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
  ...
  #endif
Comment 10 Joseph Pecoraro 2012-03-27 19:49:37 PDT 
(In reply to comment #9)
> Ahh, I think I found it. There is a bunch of this in other IDL files:

Moving this to a new bug:
<http://webkit.org/b/82419> Web Inspector: Create -[DOMNode inspect] from IDL