Bug 82361 - REGRESSION(r111641): This revision introduces a clear that is no longer necessary as of chromium revision crrev.com/128574. (Requested by twiz_ on #webkit).
Summary: REGRESSION(r111641): This revision introduces a clear that is no longer neces...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 81851
  Show dependency treegraph
 
Reported: 2012-03-27 11:43 PDT by WebKit Review Bot
Modified: 2012-04-03 09:00 PDT (History)
3 users (show)

See Also:


Attachments
ROLLOUT of r111641 (1.55 KB, patch)
2012-03-27 11:44 PDT, WebKit Review Bot
twiz: review-
twiz: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-03-27 11:43:27 PDT
http://trac.webkit.org/changeset/111641 broke the build:
This revision introduces a clear that is no longer necessary as of chromium revision crrev.com/128574. (Requested by twiz_ on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2012-03-27 11:44:09 PDT
Created attachment 134107 [details]
ROLLOUT of r111641

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Jeff Timanus 2012-03-27 11:51:32 PDT
Comment on attachment 134107 [details]
ROLLOUT of r111641

This patch is actually necessary.  The change introduced in crrev.com/128574 introduces a clear for CanvasPaintT types, which are not used in this code path.  The PlatformCanvas instance is still constructed uninitialized.
Comment 3 Jeff Timanus 2012-04-03 09:00:25 PDT
The clear is necessary.  Closing this issue.