RESOLVED FIXED 82349
[chromium] Filter context vs. webkit_unit_tests 
https://bugs.webkit.org/show_bug.cgi?id=82349
Summary [chromium] Filter context vs. webkit_unit_tests
Stephen White
Reported 2012-03-27 09:22:11 PDT
Fix failures in webkit_unit_tests and re-enable CCLayerTreeHostTestSetSingleLostContext.runMultiThread.
Attachments
Patch (4.62 KB, patch)
2012-03-27 09:26 PDT, Stephen White 		jamesr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephen White
Comment 1 2012-03-27 09:26:59 PDT
Created attachment 134084 [details] Patch
Stephen White
Comment 2 2012-03-27 09:33:34 PDT
These problems occur because the request for filter contexts is left open, and subsequent tests actually attempt to allocate a real GL context, which asserts because SetGLImplementation() hasn't been called. For now, I'm just cancelling the request for filter contexts after the occlusion tests run. A longer-term solution might be to mock out the GL context (either as the compositor context is mocked in the Web.*Client, or by calling SetGLImplementation(kGLImplementationMockGL), but since this is all probably going to change once we can create contexts in the impl thread, this will keep things running for now.
James Robinson
Comment 3 2012-03-27 09:59:37 PDT
Comment on attachment 134084 [details] Patch Seems reasonable
Stephen White
Comment 4 2012-03-27 10:03:05 PDT
Committed r112278: <http://trac.webkit.org/changeset/112278>
Note You need to log in before you can comment on or make changes to this bug.