Bug 82345 - Frame flattening: childframe in FrameView::layout() needs protector.
Summary: Frame flattening: childframe in FrameView::layout() needs protector.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Minor
Assignee: zalan
Depends on:
Reported: 2012-03-27 08:55 PDT by zalan
Modified: 2012-03-27 11:01 PDT (History)
2 users (show)

See Also:

Patch (2.14 KB, patch)
2012-03-27 10:02 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2012-03-27 08:55:54 PDT
In case of frame flattening, when the child frame is re-starting the layout from the topmost parent, childframe needs RefPtr<FrameView> protector(this); so that it won't get destroyed by a recalcStyle() call in a parent layout().

fix: move RefPtr<FrameView> protector(this); in FrameView::layout() a few lines up, before the frame flattening re-start.
Comment 1 zalan 2012-03-27 10:02:39 PDT
Created attachment 134088 [details]
Comment 2 WebKit Review Bot 2012-03-27 11:01:07 PDT
Comment on attachment 134088 [details]

Clearing flags on attachment: 134088

Committed r112283: <http://trac.webkit.org/changeset/112283>
Comment 3 WebKit Review Bot 2012-03-27 11:01:11 PDT
All reviewed patches have been landed.  Closing bug.