Bug 82341 – [GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Garcia Campos]

To be able to ignore skipped tests or run only skipped tests in addition to the default action that skips skipped tests

[Carlos Garcia Campos]

Created attachment 134065 [details]
Patch

[Martin Robinson]

Comment on attachment 134065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134065&action=review

> Tools/Scripts/run-gtk-tests:216
> +        # By default skipped test are skipped,
> +        # run them only when there are specific
> +        # test cases failing.

Super nit: This comment could probably be one line.

> Tools/Scripts/run-gtk-tests:296
> +                             help='Specifies how to treat the Skipped tests')

Nit: Skipped -> skipped

[Carlos Garcia Campos]

(In reply to comment #2)
> (From update of attachment 134065 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134065&action=review
> 
> > Tools/Scripts/run-gtk-tests:216
> > +        # By default skipped test are skipped,
> > +        # run them only when there are specific
> > +        # test cases failing.
> 
> Super nit: This comment could probably be one line.

Ok :-)

> > Tools/Scripts/run-gtk-tests:296
> > +                             help='Specifies how to treat the Skipped tests')
> 
> Nit: Skipped -> skipped

Sure, thanks!

[Eric Seidel (no email)]

Attachment 134065 [details] was posted by a committer and has review+, assigning to Carlos Garcia Campos for commit.

[Carlos Garcia Campos]

Committed r112406: <http://trac.webkit.org/changeset/112406>