Bug 82341 - [GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests
Summary: [GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: Gtk
Depends on: 82333
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-27 08:00 PDT by Carlos Garcia Campos
Modified: 2012-03-28 08:54 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.15 KB, patch)
2012-03-27 08:04 PDT, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-03-27 08:00:13 PDT
To be able to ignore skipped tests or run only skipped tests in addition to the default action that skips skipped tests
Comment 1 Carlos Garcia Campos 2012-03-27 08:04:34 PDT
Created attachment 134065 [details]
Patch
Comment 2 Martin Robinson 2012-03-27 08:15:26 PDT
Comment on attachment 134065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134065&action=review

> Tools/Scripts/run-gtk-tests:216
> +        # By default skipped test are skipped,
> +        # run them only when there are specific
> +        # test cases failing.

Super nit: This comment could probably be one line.

> Tools/Scripts/run-gtk-tests:296
> +                             help='Specifies how to treat the Skipped tests')

Nit: Skipped -> skipped
Comment 3 Carlos Garcia Campos 2012-03-27 08:18:03 PDT
(In reply to comment #2)
> (From update of attachment 134065 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134065&action=review
> 
> > Tools/Scripts/run-gtk-tests:216
> > +        # By default skipped test are skipped,
> > +        # run them only when there are specific
> > +        # test cases failing.
> 
> Super nit: This comment could probably be one line.

Ok :-)

> > Tools/Scripts/run-gtk-tests:296
> > +                             help='Specifies how to treat the Skipped tests')
> 
> Nit: Skipped -> skipped

Sure, thanks!
Comment 4 Eric Seidel (no email) 2012-03-27 12:36:49 PDT
Attachment 134065 [details] was posted by a committer and has review+, assigning to Carlos Garcia Campos for commit.
Comment 5 Carlos Garcia Campos 2012-03-28 08:54:08 PDT
Committed r112406: <http://trac.webkit.org/changeset/112406>