Bug 82332 - Construct CSSCharsetRule on CSSOM API access only
Summary: Construct CSSCharsetRule on CSSOM API access only
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 77745
  Show dependency treegraph
 
Reported: 2012-03-27 06:33 PDT by Antti Koivisto
Modified: 2012-04-11 20:52 PDT (History)
4 users (show)

See Also:


Attachments
patch (15.26 KB, patch)
2012-03-27 08:50 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-03-27 06:33:44 PDT
Charset is just a string. There is usually no need to construct CSSCharsetRule at all.
Comment 1 Antti Koivisto 2012-03-27 08:50:58 PDT
Created attachment 134078 [details]
patch
Comment 2 WebKit Review Bot 2012-03-27 08:54:09 PDT
Attachment 134078 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSStyleSheet.cpp:134:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/css/CSSStyleSheet.cpp:202:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/css/CSSStyleSheet.cpp:210:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/css/CSSStyleSheet.cpp:266:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 4 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2012-03-27 09:35:07 PDT
Comment on attachment 134078 [details]
patch

r=me

You might wanna herp where stylebot indicates that you have derped.
Comment 4 Antti Koivisto 2012-03-27 10:47:40 PDT
http://trac.webkit.org/changeset/112281