RESOLVED FIXED 82332
Construct CSSCharsetRule on CSSOM API access only 
https://bugs.webkit.org/show_bug.cgi?id=82332
Summary Construct CSSCharsetRule on CSSOM API access only
Antti Koivisto
Reported 2012-03-27 06:33:44 PDT
Charset is just a string. There is usually no need to construct CSSCharsetRule at all.
Attachments
patch (15.26 KB, patch)
2012-03-27 08:50 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2012-03-27 08:50:58 PDT
Created attachment 134078 [details] patch
WebKit Review Bot
Comment 2 2012-03-27 08:54:09 PDT
Attachment 134078 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSStyleSheet.cpp:134: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/css/CSSStyleSheet.cpp:202: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/css/CSSStyleSheet.cpp:210: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/css/CSSStyleSheet.cpp:266: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 4 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2012-03-27 09:35:07 PDT
Comment on attachment 134078 [details] patch r=me You might wanna herp where stylebot indicates that you have derped.
Antti Koivisto
Comment 4 2012-03-27 10:47:40 PDT
http://trac.webkit.org/changeset/112281
Note You need to log in before you can comment on or make changes to this bug.