Bug 82322 - Web Inspector: startEditing should remove tabIndex attribute from the element if it was not set before.
Summary: Web Inspector: startEditing should remove tabIndex attribute from the element...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-27 04:51 PDT by Vsevolod Vlasov
Modified: 2012-03-27 05:32 PDT (History)
10 users (show)

See Also:

Attachments
Patch (2.00 KB, patch)
2012-03-27 04:54 PDT, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch (2.01 KB, patch)
2012-03-27 04:54 PDT, Vsevolod Vlasov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-03-27 04:51:23 PDT 
startEditing should remove tabIndex attribute from the element if it was not set before.
Comment 1 Vsevolod Vlasov 2012-03-27 04:54:01 PDT 
Created attachment 134027 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-03-27 04:54:52 PDT 
Created attachment 134028 [details]
Patch
Comment 3 Pavel Feldman 2012-03-27 05:14:42 PDT 
Comment on attachment 134028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134028&action=review

> Source/WebCore/inspector/front-end/UIUtils.js:284
> +    if (typeof(oldTabIndex) !== "number" || oldTabIndex < 0)

typeof oldTabIndex !== "number" or use isNaN.
Comment 4 Vsevolod Vlasov 2012-03-27 05:32:25 PDT 
Committed r112257: <http://trac.webkit.org/changeset/112257>