Bug 82318 - Web Inspector: dispatch breakpoint-added and breakpoint-removed events on UISourceCode.
Summary: Web Inspector: dispatch breakpoint-added and breakpoint-removed events on UIS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks: 82224
  Show dependency treegraph
 
Reported: 2012-03-27 03:43 PDT by Pavel Podivilov
Modified: 2012-03-27 07:57 PDT (History)
11 users (show)

See Also:


Attachments
Patch (20.40 KB, patch)
2012-03-27 03:44 PDT, Pavel Podivilov
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2012-03-27 03:43:04 PDT
Web Inspector: dispatch breakpoint-added and breakpoint-removed events on UISourceCode.

See bug 82224 for rationale.
Comment 1 Pavel Podivilov 2012-03-27 03:44:37 PDT
Created attachment 134015 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-03-27 04:17:21 PDT
Comment on attachment 134015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134015&action=review

> Source/WebCore/inspector/front-end/ScriptsPanel.js:285
> +    _addBreakpointListeners: function(uiSourceCode)

Please add type annotations.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:291
> +    _removeBreakpointListeners: function(uiSourceCode)

ditto
Comment 3 Pavel Podivilov 2012-03-27 07:57:54 PDT
Committed r112266: <http://trac.webkit.org/changeset/112266>