Bug 82292 - [BlackBerry] Text selection - selection gets broken in test.com/individuals.htm
Summary: [BlackBerry] Text selection - selection gets broken in test.com/individuals.htm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-26 20:46 PDT by Sean Wang
Modified: 2012-03-27 20:47 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.16 KB, patch)
2012-03-27 01:02 PDT, Sean Wang
rwlbuis: review+
Details | Formatted Diff | Diff
Patch 2, changed Reviewed by... (5.23 KB, patch)
2012-03-27 19:12 PDT, Sean Wang
rwlbuis: review-
Details | Formatted Diff | Diff
Patch 3, Change the reviewed by... (5.25 KB, patch)
2012-03-27 19:47 PDT, Sean Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Wang 2012-03-26 20:46:10 PDT
+++ This PR was initially created as a clone of PR #131791 +++

- load test.com/individuals.htm
- start text selection from some text in the page, preferably text right bellow
"popular searches: "
- drag one of the anchors upward, so that it crosses the iframe ad at the top
left , and drop the anchor on top of "for individuals looking for tests" image

selection switches to the iframe (the ad), but the main frame selection still
exists.

Selection shouldn't cross frames.
Comment 1 Sean Wang 2012-03-27 01:02:40 PDT
Created attachment 133994 [details]
Patch
Comment 2 Rob Buis 2012-03-27 04:17:45 PDT
Comment on attachment 133994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133994&action=review

Patch looks good. Because you filled in reviewed by I cant cq+, so please ask Leo or Charles for help to land this correctly, or re-upload with proper reviewed by line.

> Source/WebKit/blackberry/ChangeLog:8
> +        Reviewed by Mike Fenton

This is wrong, you mean internally reviewed here.
Comment 3 Sean Wang 2012-03-27 19:12:09 PDT
Created attachment 134201 [details]
Patch 2, changed Reviewed by...
Comment 4 Rob Buis 2012-03-27 19:22:33 PDT
Comment on attachment 134201 [details]
Patch 2, changed Reviewed by...

View in context: https://bugs.webkit.org/attachment.cgi?id=134201&action=review

> Source/WebKit/blackberry/ChangeLog:10
> +        Reviewed by Nobody.

This will likely still not work, you need "Reviewed by NOBODY (OOPS!)."
Comment 5 Sean Wang 2012-03-27 19:47:26 PDT
Created attachment 134206 [details]
Patch 3, Change the reviewed by...
Comment 6 Rob Buis 2012-03-27 19:48:51 PDT
Comment on attachment 134206 [details]
Patch 3, Change the reviewed by...

Looks good.
Comment 7 WebKit Review Bot 2012-03-27 20:47:17 PDT
Comment on attachment 134206 [details]
Patch 3, Change the reviewed by...

Clearing flags on attachment: 134206

Committed r112361: <http://trac.webkit.org/changeset/112361>
Comment 8 WebKit Review Bot 2012-03-27 20:47:22 PDT
All reviewed patches have been landed.  Closing bug.