RESOLVED FIXED Bug 82290
test-webkitpy: prepare for better test run output
https://bugs.webkit.org/show_bug.cgi?id=82290
Summary test-webkitpy: prepare for better test run output
Dirk Pranke
Reported 2012-03-26 20:09:28 PDT
test-webkitpy: prepare for better test run output
Attachments
Patch (10.05 KB, patch)
2012-03-26 20:13 PDT, Dirk Pranke
no flags
Patch (14.64 KB, patch)
2012-03-27 11:53 PDT, Dirk Pranke
no flags
Dirk Pranke
Comment 1 2012-03-26 20:13:01 PDT
Dirk Pranke
Comment 2 2012-03-26 20:18:24 PDT
This change is a prelude to me landing logging changes for per-test timing information and a MeteredStream-style form of output. It will also be the basis for implementing parallel testing, if we decide that's worth it.
Adam Barth
Comment 3 2012-03-26 22:49:09 PDT
Comment on attachment 133967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133967&action=review > Tools/Scripts/webkitpy/test/runner.py:68 > + # FIXME: it's kinda lame that we re-load the test suites for each > + # test, and this may slow things down, but this makes implementing > + # the logging easy and will also allow us to parallelize nicely. Have you measured how much this slows us down?
Dirk Pranke
Comment 4 2012-03-27 11:45:57 PDT
(In reply to comment #3) > (From update of attachment 133967 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=133967&action=review > > > Tools/Scripts/webkitpy/test/runner.py:68 > > + # FIXME: it's kinda lame that we re-load the test suites for each > > + # test, and this may slow things down, but this makes implementing > > + # the logging easy and will also allow us to parallelize nicely. > > Have you measured how much this slows us down? A couple of unscientific tests seem to point to about a half-second slowdown on my mac pro (18.2 seconds -> 18.7). I'm actually a bit surprised that it's noticeable at all, so I'll have to dig into it further to see what the cause of this is, but I think this is well within the noise for now.
Dirk Pranke
Comment 5 2012-03-27 11:46:44 PDT
Also, I notice that this patch doesn't have the unit tests I wrote in it ... will upload those as well and then land.
Dirk Pranke
Comment 6 2012-03-27 11:53:35 PDT
Dirk Pranke
Comment 7 2012-03-27 12:16:10 PDT
Eric Seidel (no email)
Comment 8 2012-03-27 13:23:28 PDT
Comment on attachment 134110 [details] Patch Cleared review? from attachment 134110 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.