Bug 82289 - [Qt][WK2] Merge setVisibleContentsRect with setFixedVisibleContentRect
Summary: [Qt][WK2] Merge setVisibleContentsRect with setFixedVisibleContentRect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-26 19:57 PDT by Yael
Modified: 2012-03-27 07:43 PDT (History)
5 users (show)

See Also:


Attachments
Patch (13.21 KB, patch)
2012-03-26 20:01 PDT, Yael
no flags Details | Formatted Diff | Diff
Patch (3.65 KB, patch)
2012-03-27 06:07 PDT, Yael
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2012-03-26 19:57:00 PDT
As we scroll, we constantly send 2 messages. Those 2 messages can be merged into one.
Patch is coming.
Comment 1 Yael 2012-03-26 20:01:44 PDT
Created attachment 133965 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-03-26 23:39:36 PDT
Comment on attachment 133965 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133965&action=review

> Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp:448
>      scheduleLayerFlush();
> +    if (updateFixedVisibleRect)
> +        m_webPage->setFixedVisibleContentRect(rect);
>  }

I am just wondering, what is the reason this should not always be updated? in theory the fixed visible rect is just the visisble rect (used together with fixed layouting)
Comment 3 Yael 2012-03-27 05:30:38 PDT
(In reply to comment #2)
> (From update of attachment 133965 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133965&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp:448
> >      scheduleLayerFlush();
> > +    if (updateFixedVisibleRect)
> > +        m_webPage->setFixedVisibleContentRect(rect);
> >  }
> 
> I am just wondering, what is the reason this should not always be updated? in theory the fixed visible rect is just the visisble rect (used together with fixed layouting)

When running with the option --desktop, we don't want to update this.
Comment 4 Kenneth Rohde Christiansen 2012-03-27 05:43:18 PDT
But you do want to update the other because of AC? Why not just add a isUsingFixedLayout check or so?
Comment 5 Yael 2012-03-27 06:07:21 PDT
Created attachment 134042 [details]
Patch

Removed the bool and rely on useFixedLayout() instead.
Comment 6 WebKit Review Bot 2012-03-27 07:43:03 PDT
Comment on attachment 134042 [details]
Patch

Clearing flags on attachment: 134042

Committed r112265: <http://trac.webkit.org/changeset/112265>
Comment 7 WebKit Review Bot 2012-03-27 07:43:08 PDT
All reviewed patches have been landed.  Closing bug.