Bug 82289 – [Qt][WK2] Merge setVisibleContentsRect with setFixedVisibleContentRect

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Yael]

As we scroll, we constantly send 2 messages. Those 2 messages can be merged into one.
Patch is coming.

[Yael]

Created attachment 133965 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 133965 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133965&action=review

> Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp:448
>      scheduleLayerFlush();
> +    if (updateFixedVisibleRect)
> +        m_webPage->setFixedVisibleContentRect(rect);
>  }

I am just wondering, what is the reason this should not always be updated? in theory the fixed visible rect is just the visisble rect (used together with fixed layouting)

[Yael]

(In reply to comment #2)
> (From update of attachment 133965 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133965&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp:448
> >      scheduleLayerFlush();
> > +    if (updateFixedVisibleRect)
> > +        m_webPage->setFixedVisibleContentRect(rect);
> >  }
> 
> I am just wondering, what is the reason this should not always be updated? in theory the fixed visible rect is just the visisble rect (used together with fixed layouting)

When running with the option --desktop, we don't want to update this.

[Kenneth Rohde Christiansen]

But you do want to update the other because of AC? Why not just add a isUsingFixedLayout check or so?

[Yael]

Created attachment 134042 [details]
Patch

Removed the bool and rely on useFixedLayout() instead.

[WebKit Review Bot]

Comment on attachment 134042 [details]
Patch

Clearing flags on attachment: 134042

Committed r112265: <http://trac.webkit.org/changeset/112265>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.