Bug 82283 - ImageLoader::m_firedLoadEvent is a confusing name
Summary: ImageLoader::m_firedLoadEvent is a confusing name
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-26 18:39 PDT by WebKit Review Bot
Modified: 2012-03-27 14:30 PDT (History)
5 users (show)

See Also:

Attachments
Patch (12.02 KB, patch)
2012-03-26 22:56 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-03-26 18:39:01 PDT 
Clean up ImageLoader::m_firedLoadEvent
Requested by abarth on #webkit.
Comment 1 Adam Barth 2012-03-26 22:56:15 PDT 
Created attachment 133980 [details]
Patch
Comment 2 Kentaro Hara 2012-03-26 23:04:03 PDT 
Comment on attachment 133980 [details]
Patch

OK
Comment 3 WebKit Review Bot 2012-03-27 00:21:55 PDT 
Comment on attachment 133980 [details]
Patch

Clearing flags on attachment: 133980

Committed r112215: <http://trac.webkit.org/changeset/112215>
Comment 4 WebKit Review Bot 2012-03-27 00:21:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2012-03-27 14:21:44 PDT 
I had an abandoned patch for the same some time ago, <https://bugs.webkit.org/attachment.cgi?id=76669&action=review>. It got stuck because it was trying to do too much at once.

Now that you're at it, perhaps you'll have the interest to finish the job, and make script elements sensible, too?
Comment 6 Adam Barth 2012-03-27 14:30:30 PDT 
> Now that you're at it, perhaps you'll have the interest to finish the job, and make script elements sensible, too?

Yeah, I saw the script element one in my grep as well.  I'm happy to change that one too.