Bug 82282 - Clean up Document::canNavigate
Summary: Clean up Document::canNavigate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-26 18:38 PDT by WebKit Review Bot
Modified: 2012-04-01 19:43 PDT (History)
2 users (show)

See Also:

Attachments
Patch (8.00 KB, patch)
2012-04-01 18:01 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (12.70 KB, patch)
2012-04-01 19:01 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (12.71 KB, patch)
2012-04-01 19:05 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-03-26 18:38:46 PDT 
Clean up Document::canNavigate
Requested by abarth on #webkit.
Comment 1 Adam Barth 2012-04-01 18:01:57 PDT 
Created attachment 135016 [details]
Patch
Comment 2 Adam Barth 2012-04-01 19:01:22 PDT 
Created attachment 135018 [details]
Patch
Comment 3 Eric Seidel (no email) 2012-04-01 19:03:54 PDT 
Comment on attachment 135018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135018&action=review

OK.  Looks like there is still a little work here.

> Source/WebCore/dom/Document.cpp:383
> +    // FIXME: should we print to the console of the activeFrame as well?

This fixme seems in the wrong place now.
Comment 4 Adam Barth 2012-04-01 19:05:50 PDT 
Created attachment 135019 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-04-01 19:43:36 PDT 
Comment on attachment 135019 [details]
Patch for landing

Clearing flags on attachment: 135019

Committed r112825: <http://trac.webkit.org/changeset/112825>
Comment 6 WebKit Review Bot 2012-04-01 19:43:41 PDT 
All reviewed patches have been landed.  Closing bug.