IndexedDB: don't expose IDBDatabaseError to script
Created attachment 133953 [details] Patch
Josh, this will need rebaselining of our expected files, but do you know any reason why we can't remove this?
Comment on attachment 133953 [details] Patch Attachment 133953 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12141259
Comment on attachment 133953 [details] Patch Attachment 133953 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12103038
Comment on attachment 133953 [details] Patch Attachment 133953 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12147227
(In reply to comment #2) > Josh, this will need rebaselining of our expected files, but do you know any reason why we can't remove this? We can remove it. (IDBDatabaseException will be going away too as part of a move to DOM4-style exceptions, but not all of the other browsers have done that yet either.)
Created attachment 134080 [details] Patch
Attachment 134080 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/stor..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 134085 [details] Patch
Comment on attachment 134085 [details] Patch Attachment 134085 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12148520
Created attachment 134136 [details] Patch
Josh, do you want to take a look before I ask Tony to review this?
Comment on attachment 134136 [details] Patch lgtm View in context: https://bugs.webkit.org/attachment.cgi?id=134136&action=review > Source/WebCore/GNUmakefile.list.am:-1059 > - Source/WebCore/Modules/indexeddb/IDBDatabaseError.h \ If we need to update more than gyp and xcode project files then I may be guilty of letting these get out of sync. :(
Created attachment 134150 [details] Patch
Created attachment 134151 [details] Patch
Tony, could you review this?
Comment on attachment 134151 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134151&action=review > Source/WebCore/ChangeLog:10 > + No new tests - this was an untested feature. Nit: This isn't entirely true. The existence of IDBDatabaseError was tested in the existing tests and now it's going away. If you wanted, you could check in a single test that IDBDatabaseError is undefined.
Created attachment 134447 [details] Patch
Created attachment 134449 [details] Patch
(In reply to comment #17) > (From update of attachment 134151 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134151&action=review > > > Source/WebCore/ChangeLog:10 > > + No new tests - this was an untested feature. > > Nit: This isn't entirely true. The existence of IDBDatabaseError was tested in the existing tests and now it's going away. Good point. > If you wanted, you could check in a single test that IDBDatabaseError is undefined. I added this in removed.html.
Comment on attachment 134449 [details] Patch Clearing flags on attachment: 134449 Committed r112490: <http://trac.webkit.org/changeset/112490>
All reviewed patches have been landed. Closing bug.