Bug 82276 - Speech* files should be moved from page/ to Modules/speech/
Summary: Speech* files should be moved from page/ to Modules/speech/
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 79327
  Show dependency treegraph
 
Reported: 2012-03-26 17:56 PDT by Hajime Morrita
Modified: 2017-07-18 08:29 PDT (History)
4 users (show)

See Also:


Attachments
Working in Progress - for chromium, gtk and efl (83.61 KB, patch)
2012-07-08 15:40 PDT, Gyuyoung Kim
gyuyoung.kim: review-
webkit-ews: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-03-26 17:56:20 PDT
It looks there is no reason to stay there.
Comment 1 Gyuyoung Kim 2012-07-08 15:40:54 PDT
Created attachment 151166 [details]
Working in Progress - for chromium, gtk and efl

Hello Hajime,

Do you think this bug is still valid ? If so, I make a patch for chromium, gtk, and efl in order to help you fix this bug. If you don't have time, I'm able to submit a patch for all ports.
Comment 2 Early Warning System Bot 2012-07-08 15:54:33 PDT
Comment on attachment 151166 [details]
Working in Progress - for chromium, gtk and efl

Attachment 151166 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13166047
Comment 3 Early Warning System Bot 2012-07-08 15:54:53 PDT
Comment on attachment 151166 [details]
Working in Progress - for chromium, gtk and efl

Attachment 151166 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13160244
Comment 4 Build Bot 2012-07-08 15:58:42 PDT
Comment on attachment 151166 [details]
Working in Progress - for chromium, gtk and efl

Attachment 151166 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13151977
Comment 5 Build Bot 2012-07-08 16:09:30 PDT
Comment on attachment 151166 [details]
Working in Progress - for chromium, gtk and efl

Attachment 151166 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13157660
Comment 6 Adam Barth 2012-07-08 18:22:01 PDT
Comment on attachment 151166 [details]
Working in Progress - for chromium, gtk and efl

Isn't there an include from HTMLInputElement to speech?
Comment 7 Adam Barth 2012-07-08 18:23:25 PDT
I haven't fully chased this down, but there are at least some mentions of speech in HTMLInputElement:

http://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLInputElement.cpp#L658
Comment 8 Gyuyoung Kim 2012-07-08 19:07:54 PDT
To my quick searching, below files are related to INPUT_SPEECH macro.

 - css/CSSPrimitiveValueMappings.h
 - dom/Element.h
 - html/TextFieldInputType.h
 - html/HTMLInputElement.h
 - html/HTMLInputElement.cpp
 - html/shadow/TextControlInnerElements.h
 - html/InputType.h
 - html/TextFieldInputType.cpp

I'm not sure whether page/SpeechInputXXX files can be moved to Modules/speech. It seems to me SpeechInput is used more than other modules out of Modules directory. Adam, I'd like to know how do you think this ?
Comment 9 Adam Barth 2012-07-08 20:45:14 PDT
The idea behind Modules is that there shouldn't be any references to things inside the module from things outside the module (except perhaps from bindings or the inspector).  I suspect that this speech code is too tightly coupled to the input element to be a separate module at this point.
Comment 10 Gyuyoung Kim 2012-07-08 21:20:25 PDT
(In reply to comment #9)
> The idea behind Modules is that there shouldn't be any references to things inside the module from things outside the module (except perhaps from bindings or the inspector).  I suspect that this speech code is too tightly coupled to the input element to be a separate module at this point.

BTW, it looks that files outside the modules only use them to support input speech button. In this case, can't we move it to Modules/speech ? If so, I think this bug needs to be closed.