Bug 82265 – [chromium] Add isInputThrottled/didBecomeReadyForAddionalInput to WebWidget to fix input throttling

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Nat Duca]

[chromium] Fix input flow control in threaded compositing mode

[Nat Duca]

Created attachment 133933 [details]
Patch

[Nat Duca]

This is a temporary fix due to M19 timing and this causing jank there. We will fix this properly with 80977

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Attachment 133933 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[James Robinson]

Comment on attachment 133933 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133933&action=review

> Source/WebKit/chromium/ChangeLog:3
> +        [chromium] Fix input flow control in threaded compositing mode

this isn't terribly descriptive - can you change the title to describe what this patch actually has and put some prose in the body of the ChangeLog describing the expected semantics / flow of these calls?

> Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:241
> +    ASSERT_NOT_REACHED();

what's keeping this from being hit? is the expectation that chromium-side code will only call WebWidget::isInputThrottled() if it is not handling scheduling (i.e. WebWidgetHandlesCompositorScheduling() is true)? if so you should document that on WebWidget. Might be easier to just have this return false and have the chromium code unconditionally check

> Source/WebKit/chromium/public/WebWidgetClient.h:77
> +    // FIXME: Make pure virtual once upstream deps are satisfied.

it doesn't look like anything else in this file is pure virtual

[Nat Duca]

Created attachment 133938 [details]
Patch

[Nat Duca]

Created attachment 133939 [details]
oops

[James Robinson]

Comment on attachment 133939 [details]
oops

Cool. R=me

[Nat Duca]

Committed r112191: <http://trac.webkit.org/changeset/112191>