[chromium] Fix input flow control in threaded compositing mode
Created attachment 133933 [details]
This is a temporary fix due to M19 timing and this causing jank there. We will fix this properly with 80977
Please wait for approval from firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com or firstname.lastname@example.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Attachment 133933 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] 
Total errors found: 1 in 21 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 133933 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=133933&action=review
> + [chromium] Fix input flow control in threaded compositing mode
this isn't terribly descriptive - can you change the title to describe what this patch actually has and put some prose in the body of the ChangeLog describing the expected semantics / flow of these calls?
> + ASSERT_NOT_REACHED();
what's keeping this from being hit? is the expectation that chromium-side code will only call WebWidget::isInputThrottled() if it is not handling scheduling (i.e. WebWidgetHandlesCompositorScheduling() is true)? if so you should document that on WebWidget. Might be easier to just have this return false and have the chromium code unconditionally check
> + // FIXME: Make pure virtual once upstream deps are satisfied.
it doesn't look like anything else in this file is pure virtual
Created attachment 133938 [details]
Created attachment 133939 [details]
Comment on attachment 133939 [details]
Committed r112191: <http://trac.webkit.org/changeset/112191>