Bug 82263 - [chromium] Add virtual test suite for threaded compositing
: [chromium] Add virtual test suite for threaded compositing
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
: 82405 82486
:
  Show dependency treegraph
 
Reported: 2012-03-26 17:00 PST by
Modified: 2012-04-06 18:10 PST (History)


Attachments
Patch (17.52 KB, patch)
2012-03-26 17:28 PST, Adrienne Walker
no flags Review Patch | Details | Formatted Diff | Diff
Only enable for compositing/visibility (2.17 KB, patch)
2012-04-06 13:35 PST, Adrienne Walker
jamesr: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-03-26 17:00:58 PST
[chromium] Add virtual test suite for threaded compositing
------- Comment #1 From 2012-03-26 17:28:43 PST -------
Created an attachment (id=133937) [details]
Patch
------- Comment #2 From 2012-03-26 17:38:33 PST -------
Hm, it passes every test that passes in the non-threaded mode? Color me pleasantly surprised!
------- Comment #3 From 2012-03-26 17:42:49 PST -------
(In reply to comment #2)
> Hm, it passes every test that passes in the non-threaded mode? Color me pleasantly surprised!

The joke's on you.  DRT doesn't properly obey the --enable-threaded-compositing flag.  :(
------- Comment #4 From 2012-03-26 17:43:57 PST -------
I think it'll probably take about one more test suite to convince me that we need to support test expectation inheritance as well (if even that).
------- Comment #5 From 2012-04-06 13:35:16 PST -------
Created an attachment (id=136057) [details]
Only enable for compositing/visibility
------- Comment #6 From 2012-04-06 13:41:16 PST -------
(From update of attachment 136057 [details])
Nice
------- Comment #7 From 2012-04-06 13:43:24 PST -------
(From update of attachment 136057 [details])
Holy crap, this virtual suite stuff is sweet!! Ok, I am done with puns for today.
------- Comment #8 From 2012-04-06 18:10:10 PST -------
Committed r113529: <http://trac.webkit.org/changeset/113529>