Bug 82263 - [chromium] Add virtual test suite for threaded compositing
Summary: [chromium] Add virtual test suite for threaded compositing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on: 82405 82486
Blocks:
  Show dependency tree / graph
 
Reported: 2012-03-26 17:00 PDT by Adrienne Walker
Modified: 2012-04-06 18:10 PDT (History)
6 users (show)

See Also:

Attachments
Patch (17.52 KB, patch)
2012-03-26 17:28 PDT, Adrienne Walker 		no flags Details | Formatted Diff | Diff
Only enable for compositing/visibility (2.17 KB, patch)
2012-04-06 13:35 PDT, Adrienne Walker 		jamesr: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2012-03-26 17:00:58 PDT 
[chromium] Add virtual test suite for threaded compositing
Comment 1 Adrienne Walker 2012-03-26 17:28:43 PDT 
Created attachment 133937 [details]
Patch
Comment 2 James Robinson 2012-03-26 17:38:33 PDT 
Hm, it passes every test that passes in the non-threaded mode? Color me pleasantly surprised!
Comment 3 Adrienne Walker 2012-03-26 17:42:49 PDT 
(In reply to comment #2)
> Hm, it passes every test that passes in the non-threaded mode? Color me pleasantly surprised!

The joke's on you.  DRT doesn't properly obey the --enable-threaded-compositing flag.  :(
Comment 4 Dirk Pranke 2012-03-26 17:43:57 PDT 
I think it'll probably take about one more test suite to convince me that we need to support test expectation inheritance as well (if even that).
Comment 5 Adrienne Walker 2012-04-06 13:35:16 PDT 
Created attachment 136057 [details]
Only enable for compositing/visibility
Comment 6 James Robinson 2012-04-06 13:41:16 PDT 
Comment on attachment 136057 [details]
Only enable for compositing/visibility

Nice
Comment 7 Dimitri Glazkov (Google) 2012-04-06 13:43:24 PDT 
Comment on attachment 136057 [details]
Only enable for compositing/visibility

Holy crap, this virtual suite stuff is sweet!! Ok, I am done with puns for today.
Comment 8 Adrienne Walker 2012-04-06 18:10:10 PDT 
Committed r113529: <http://trac.webkit.org/changeset/113529>