Bug 82256 - Always set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap::set()
Summary: Always set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakRefe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Klein
URL:
Keywords:
Depends on: 82295 82912 83528
Blocks:
  Show dependency tree / graph
 
Reported: 2012-03-26 16:17 PDT by Adam Klein
Modified: 2012-04-12 14:12 PDT (History)
7 users (show)

See Also:

Attachments
Patch (17.39 KB, patch)
2012-03-26 16:19 PDT, Adam Klein 		no flags Details | Formatted Diff | Diff
Fix isActiveNode assert (17.39 KB, patch)
2012-03-26 16:37 PDT, Adam Klein 		no flags Details | Formatted Diff | Diff
Patch for relanding (17.44 KB, patch)
2012-03-27 10:08 PDT, Adam Klein 		no flags Details | Formatted Diff | Diff
Patch (11.08 KB, patch)
2012-04-11 15:31 PDT, Adam Klein 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Klein 2012-03-26 16:17:11 PDT 
Always set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap::set()
Comment 1 Adam Klein 2012-03-26 16:19:25 PDT 
Created attachment 133922 [details]
Patch
Comment 2 Adam Klein 2012-03-26 16:37:04 PDT 
Created attachment 133925 [details]
Fix isActiveNode assert
Comment 3 WebKit Review Bot 2012-03-26 19:58:46 PDT 
Comment on attachment 133925 [details]
Fix isActiveNode assert

Clearing flags on attachment: 133925

Committed r112199: <http://trac.webkit.org/changeset/112199>
Comment 4 WebKit Review Bot 2012-03-26 19:58:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Adam Klein 2012-03-27 10:00:39 PDT 
Got rolled out, just need to properly define SVGElemetInstance to fix cr-win build.
Comment 6 Adam Klein 2012-03-27 10:08:24 PDT 
Created attachment 134089 [details]
Patch for relanding
Comment 7 Adam Klein 2012-03-27 14:38:43 PDT 
Committed r112318: <http://trac.webkit.org/changeset/112318>
Comment 8 Adam Klein 2012-04-09 16:57:52 PDT 
This was rolled out.
Comment 9 Adam Klein 2012-04-11 15:31:20 PDT 
Created attachment 136768 [details]
Patch
Comment 10 Kentaro Hara 2012-04-11 20:41:19 PDT 
Comment on attachment 136768 [details]
Patch

Looks OK.
Comment 11 WebKit Review Bot 2012-04-12 14:11:56 PDT 
Comment on attachment 136768 [details]
Patch

Clearing flags on attachment: 136768

Committed r114034: <http://trac.webkit.org/changeset/114034>
Comment 12 WebKit Review Bot 2012-04-12 14:12:01 PDT 
All reviewed patches have been landed.  Closing bug.