Bug 82248 – Don't manually set an identifier for main resource loads in FrameLoader

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Nate Chapin]

Currently, we create an identifier and assign it to the ResourceRequest for a main resource load in FrameLoader just before we create the MainResourceLoader.  We then pass the identifier into the MainResourceLoader immediately after it is created.  Given that the MainResourceLoader would have created and set an identifier shortly thereafter (when willSendRequest is called for the initial request), I can't figure out why we need this extra code in FrameLoader.

[Nate Chapin]

Created attachment 133898 [details]
patch

[Nate Chapin]

Created attachment 133904 [details]
Hopefully EWS-able now

[Adam Barth]

Comment on attachment 133904 [details]
Hopefully EWS-able now

Thanks for digging through the history to figure out when this code was added.

[WebKit Review Bot]

Comment on attachment 133904 [details]
Hopefully EWS-able now

Rejecting attachment 133904 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
    self._run(tool, options, state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://queues.webkit.org/results/12142691

[Nate Chapin]

(In reply to comment #4)
> (From update of attachment 133904 [details])
> Rejecting attachment 133904 [details] from commit-queue.
> 
> Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1
> 
> Last 500 characters of output:
> ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
>     self._run(tool, options, state)
>   File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
>     step(tool, options).run(state)
>   File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in run
>     if changelog_entry.has_valid_reviewer():
> AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'
> 
> Full output: http://queues.webkit.org/results/12142691

Landed manually: http://trac.webkit.org/changeset/112308