Bug 82247 - Find in page overlay and bouncy are not always positioned correctly
Summary: Find in page overlay and bouncy are not always positioned correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-26 14:29 PDT by Anders Carlsson
Modified: 2012-03-26 14:44 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.74 KB, patch)
2012-03-26 14:32 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-03-26 14:29:19 PDT
Find in page overlay and bouncy are not always positioned correctly
Comment 1 Anders Carlsson 2012-03-26 14:32:53 PDT
Created attachment 133894 [details]
Patch
Comment 2 Sam Weinig 2012-03-26 14:37:12 PDT
Comment on attachment 133894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133894&action=review

> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:227
> +    // Assume that we'll be successful in updating the scroll position.
> +    updateMainFrameScrollPosition(scrollPosition);

Can you explain what happens if that assumption doesn't hold, and how we deal with it?
Comment 3 Anders Carlsson 2012-03-26 14:42:20 PDT
(In reply to comment #2)
> (From update of attachment 133894 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133894&action=review
> 
> > Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:227
> > +    // Assume that we'll be successful in updating the scroll position.
> > +    updateMainFrameScrollPosition(scrollPosition);
> 
> Can you explain what happens if that assumption doesn't hold, and how we deal with it?

Thinking about it, I'm pretty sure that the assumption will hold so I updated the comment.
Comment 4 Anders Carlsson 2012-03-26 14:42:22 PDT
(In reply to comment #2)
> (From update of attachment 133894 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133894&action=review
> 
> > Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:227
> > +    // Assume that we'll be successful in updating the scroll position.
> > +    updateMainFrameScrollPosition(scrollPosition);
> 
> Can you explain what happens if that assumption doesn't hold, and how we deal with it?

Thinking about it, I'm pretty sure that the assumption will hold so I updated the comment.
Comment 5 Anders Carlsson 2012-03-26 14:44:09 PDT
Committed r112148: <http://trac.webkit.org/changeset/112148>