Bug 82241 - NRWT should retry failures serially
Summary: NRWT should retry failures serially
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
Depends on:
Reported: 2012-03-26 13:51 PDT by Mark Hahnenberg
Modified: 2012-03-26 17:13 PDT (History)
5 users (show)

See Also:

Patch (1.48 KB, patch)
2012-03-26 14:15 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Patch (2.53 KB, patch)
2012-03-26 14:28 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Patch (3.04 KB, patch)
2012-03-26 14:47 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-03-26 13:51:02 PDT
Some test failures are caused by the large amount parallelism that NRWT employs which can stress some parts of whatever platform the tests are running on (e.g. see bug 82233). At the conclusion of the parallel stage, we should run the failures serially rather than in parallel so that we can eliminate these errors as a factor in test failures.
Comment 1 Mark Hahnenberg 2012-03-26 14:15:45 PDT
Created attachment 133891 [details]
Comment 2 Dirk Pranke 2012-03-26 14:18:40 PDT
Comment on attachment 133891 [details]

I'm a bit concerned about what side effects modifying the value in the options might have ... have you run this through test-webkitpy?

I was actually more envisioning that you'd pass in the # of workers to use to _run_tests(), which I think (should?) be a safer change, but I suppose that might have unexpected ramifications as well.
Comment 3 Mark Hahnenberg 2012-03-26 14:28:37 PDT
Created attachment 133893 [details]
Comment 4 Dirk Pranke 2012-03-26 14:41:06 PDT
Comment on attachment 133893 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=133893&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:710
> +    def _run_tests(self, file_list, result_summary, num_workers=0):

Sorry for all the nitpicking, but I usually only like to use optional parameters as a last choice. You should be able to just pass in num_workers to both places it's called (line 897 and line 911), and then change line 751 to min(num_workers, len(all_shards).
Comment 5 Mark Hahnenberg 2012-03-26 14:47:53 PDT
Created attachment 133897 [details]
Comment 6 Mark Hahnenberg 2012-03-26 14:50:21 PDT
> Sorry for all the nitpicking...

Not a problem :-) When in Rome...
Comment 7 WebKit Review Bot 2012-03-26 17:13:10 PDT
Comment on attachment 133897 [details]

Clearing flags on attachment: 133897

Committed r112181: <http://trac.webkit.org/changeset/112181>
Comment 8 WebKit Review Bot 2012-03-26 17:13:15 PDT
All reviewed patches have been landed.  Closing bug.