Bug 82237 - [chromium] assertion being hit in CCLayerAnimationController
Summary: [chromium] assertion being hit in CCLayerAnimationController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: vollick
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-26 13:24 PDT by Shawn Singh
Modified: 2012-03-30 11:40 PDT (History)
7 users (show)

See Also:


Attachments
Patch (6.09 KB, patch)
2012-03-30 08:51 PDT, vollick
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Singh 2012-03-26 13:24:25 PDT
Approximately line 244, CCLayerAnimationController::pushNewAnimationsToImplThread(...)
   ASSERT(m_activeAnimations[i]0>needsSynchronizedStartTime())

I'm hitting this assertion on desktop aura.

To reproduce:
 1. open poster circle, apple iphone, gmail  (with --force-compositing-mode)
 2. switch tabs a few times.  At some point when switching to poster circle, it triggers this assert and crashes the page.
Comment 1 Shawn Singh 2012-03-26 13:52:46 PDT
Dana did you mean to dupe this one instead?
Comment 2 Dana Jansens 2012-03-26 13:58:51 PDT
Nope this is different, I didn't hear of this before. Ian may have to look at this.
Comment 3 vollick 2012-03-30 08:51:31 PDT
Created attachment 134821 [details]
Patch

When pushing 'new' animations to the impl thread, the old code did not consider that
the animation may be missing on the impl thread because it has already completed. In
that case, the old animation would have already notified that it had started and the
main thread animation would no longer need a synchronized start time.
Comment 4 James Robinson 2012-03-30 10:37:32 PDT
Comment on attachment 134821 [details]
Patch

Cool, R=me
Comment 5 WebKit Review Bot 2012-03-30 11:39:58 PDT
Comment on attachment 134821 [details]
Patch

Clearing flags on attachment: 134821

Committed r112701: <http://trac.webkit.org/changeset/112701>
Comment 6 WebKit Review Bot 2012-03-30 11:40:02 PDT
All reviewed patches have been landed.  Closing bug.