Bug 82221 – Add rounding to Plugin creation in SubframeLoader

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Levi Weintraub]

Widgets are always positioned at pixel boundaries, so we're safe to round the sizes. We need to do so in SubframeLoader when we create plugins.

[Levi Weintraub]

This depends on the patch to 82196 because it uses LayoutRect::pixelSnappedSize().

[Levi Weintraub]

On second look, we only need rounding, not pixel snapping. Patch forthcoming.

[Levi Weintraub]

Created attachment 134046 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 134046 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134046&action=review

> Source/WebCore/loader/SubframeLoader.cpp:363
> +    IntSize contentSize = roundedIntSize(LayoutSize(renderer->contentWidth(), renderer->contentHeight()));

Really?  No contentSize()?

[Levi Weintraub]

(In reply to comment #4)
> (From update of attachment 134046 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134046&action=review
> 
> > Source/WebCore/loader/SubframeLoader.cpp:363
> > +    IntSize contentSize = roundedIntSize(LayoutSize(renderer->contentWidth(), renderer->contentHeight()));
> 
> Really?  No contentSize()?

I thought the same thing initially, but then declined to implement it to prevent misuse. This should only be rounded when dealing with Widgets. Otherwise, it should be pixel snapped, which requires more work (but in the case of Widgets, would yield the same value... perhaps this is premature optimization?).

[WebKit Review Bot]

Comment on attachment 134046 [details]
Patch

Clearing flags on attachment: 134046

Committed r112852: <http://trac.webkit.org/changeset/112852>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.