Bug 82213 - Convert RenderSelectionInfo::rect to LayoutUnits
Summary: Convert RenderSelectionInfo::rect to LayoutUnits
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2012-03-26 08:24 PDT by Levi Weintraub
Modified: 2012-03-27 03:54 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.46 KB, patch)
2012-03-26 08:26 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-03-26 08:24:18 PDT 
RenderSelectionInfoBase stores a cached repaint rect in local coordinates, and therefor should store it in LayoutUnits.
Comment 1 Levi Weintraub 2012-03-26 08:26:59 PDT 
Created attachment 133818 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-03-26 15:42:49 PDT 
Comment on attachment 133818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133818&action=review

> Source/WebCore/ChangeLog:9
> +        RenderSelectionInfoBase stores a cached repaint rect in local coordinates. Coordinates local to
> +        renderers should be stored in LayoutUnits.

I think these sorts of changelogs might link to the wiki.

Ending in "As described in LayoutUnit: http://trac.webkit.org/wiki/LayoutUnit"
Comment 3 Eric Seidel (no email) 2012-03-26 15:43:11 PDT 
Comment on attachment 133818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133818&action=review

>> Source/WebCore/ChangeLog:9
>> +        renderers should be stored in LayoutUnits.
> 
> I think these sorts of changelogs might link to the wiki.
> 
> Ending in "As described in LayoutUnit: http://trac.webkit.org/wiki/LayoutUnit"

Obviously this means that then the wiki would need to make sure to include this sort of rational. :)
Comment 4 Levi Weintraub 2012-03-27 03:53:03 PDT 
Committed r112248: <http://trac.webkit.org/changeset/112248>
Comment 5 Levi Weintraub 2012-03-27 03:54:45 PDT 
Comment on attachment 133818 [details]
Patch

Clearing flags.