Bug 82211 - [BlackBerry] Disable DisallowCType.h usage
Summary: [BlackBerry] Disable DisallowCType.h usage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-26 08:15 PDT by Rob Buis
Modified: 2012-03-27 08:44 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2012-03-26 22:03 PDT, Ming Xie 		no flags Details | Formatted Diff | Diff
Patch (1.39 KB, patch)
2012-03-26 22:26 PDT, Ming Xie 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2012-03-26 08:15:09 PDT 
We do rely on ctype.h internally, so right now we run into compile problems (Geolocation.cpp).
Comment 1 Ming Xie 2012-03-26 22:03:32 PDT 
Created attachment 133973 [details]
Patch
Comment 2 Ming Xie 2012-03-26 22:26:29 PDT 
Created attachment 133976 [details]
Patch
Comment 3 Rob Buis 2012-03-27 04:12:20 PDT 
Comment on attachment 133976 [details]
Patch

Looks good, thanks! One thing I forgot, there is a similar case in JavaScriptCore, can you do that one too in this patch?
Comment 4 Rob Buis 2012-03-27 07:58:43 PDT 
Comment on attachment 133976 [details]
Patch

False alarm, the one in JSC is already fixed.
Comment 5 WebKit Review Bot 2012-03-27 08:44:30 PDT 
Comment on attachment 133976 [details]
Patch

Clearing flags on attachment: 133976

Committed r112275: <http://trac.webkit.org/changeset/112275>
Comment 6 WebKit Review Bot 2012-03-27 08:44:35 PDT 
All reviewed patches have been landed.  Closing bug.