Bug 82206 – Revert RenderApplet::intrinsicSize to integers

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Levi Weintraub]

Intrinsic sizes originate either outside of WebCore, or from constant integers. There is no need for them to be LayoutUnits. In the process of looking through our usage, I also identified some dead code I'm removing.

[Levi Weintraub]

Created attachment 133809 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 133809 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133809&action=review

> Source/WebCore/rendering/RenderReplaced.cpp:-205
> -int RenderReplaced::computeIntrinsicLogicalWidth(RenderBox* contentRenderer, bool includeMaxWidth) const

Really?  Dead?

[Levi Weintraub]

(In reply to comment #2)
> (From update of attachment 133809 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133809&action=review
> 
> > Source/WebCore/rendering/RenderReplaced.cpp:-205
> > -int RenderReplaced::computeIntrinsicLogicalWidth(RenderBox* contentRenderer, bool includeMaxWidth) const
> 
> Really?  Dead?

I know... I was amazed, too, but I did my due diligence with grep. You can also note that they're non-virtual private functions and have now passed all EWS bots as well. Dead dead dead!

[WebKit Review Bot]

Comment on attachment 133809 [details]
Patch

Rejecting attachment 133809 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
rce/WebCore/rendering/RenderReplaced.cpp
Hunk #1 FAILED at 202.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderReplaced.cpp.rej
patching file Source/WebCore/rendering/RenderReplaced.h
Hunk #1 FAILED at 63.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderReplaced.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12141453

[Levi Weintraub]

(In reply to comment #4)
> (From update of attachment 133809 [details])
> Rejecting attachment 133809 [details] from commit-queue.
> 
> Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2
> 
> Last 500 characters of output:
> rce/WebCore/rendering/RenderReplaced.cpp
> Hunk #1 FAILED at 202.
> 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderReplaced.cpp.rej
> patching file Source/WebCore/rendering/RenderReplaced.h
> Hunk #1 FAILED at 63.
> 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderReplaced.h.rej
> 
> Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/
> 
> Full output: http://queues.webkit.org/results/12141453

Zimmerman beat me to it! I'll stick to the first part :)

[Levi Weintraub]

Created attachment 134018 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 134018 [details]
Patch for landing

Clearing flags on attachment: 134018

Committed r112255: <http://trac.webkit.org/changeset/112255>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.