Bug 82194 – Web Inspector: Some user objects are missing in dominators view

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexei Filippov]

It is not possible to hide internal objects in dominators tree view because these objects may happen to contain other user objects that should not be hidden.

[Alexei Filippov]

Created attachment 133785 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 133785 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133785&action=review

> Source/WebCore/inspector/front-end/HeapSnapshot.js:234
> +        return this._snapshot[this._arrayName].subarray(this._start + start, this._start + end);

Why did this change? Is it a bug?

[Alexei Filippov]

Comment on attachment 133785 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133785&action=review

>> Source/WebCore/inspector/front-end/HeapSnapshot.js:234
>> +        return this._snapshot[this._arrayName].subarray(this._start + start, this._start + end);
> 
> Why did this change? Is it a bug?

Yep, it is not related to the main change. I just noticed it and decided to fix.
end should be relative to this._start when it is passed in,
and it should be the end of the outer slice (i.e. this._start + this.length) when it is not.

[Yury Semikhatsky]

(In reply to comment #3)
> (From update of attachment 133785 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133785&action=review
> 
> >> Source/WebCore/inspector/front-end/HeapSnapshot.js:234
> >> +        return this._snapshot[this._arrayName].subarray(this._start + start, this._start + end);
> > 
> > Why did this change? Is it a bug?
> 
> Yep, it is not related to the main change. I just noticed it and decided to fix.
> end should be relative to this._start when it is passed in,
> and it should be the end of the outer slice (i.e. this._start + this.length) when it is not.

Does it break anything? If so, can we cover it with a test?

[Alexei Filippov]

Created attachment 133834 [details]
Patch

[Alexei Filippov]

It seems to be always called with slice(0, undef) parameters. For this exact parameters set it works as expected. Added a test for other cases.

[Yury Semikhatsky]

Comment on attachment 133834 [details]
Patch

Clearing flags on attachment: 133834

Committed r112262: <http://trac.webkit.org/changeset/112262>

[Yury Semikhatsky]

All reviewed patches have been landed.  Closing bug.