Bug 82187 - [Qt] Assert in GestureTapHighlighter
Summary: [Qt] Assert in GestureTapHighlighter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-26 04:03 PDT by Allan Sandfeld Jensen
Modified: 2012-03-26 04:57 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.94 KB, patch)
2012-03-26 04:06 PDT, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-03-26 04:03:10 PDT 
When clicking on a link you will occationally trigger the two ASSERTs addHighlightRect.
    ASSERT(!rect.intersects(prev));
    ASSERT(!rect.intersects(next));

It appears to be possible because the center-block is adjusted to the boundaries of first and last rect, after it has been tested if it intersects with first or last.
Comment 1 Allan Sandfeld Jensen 2012-03-26 04:06:39 PDT 
Created attachment 133770 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-03-26 04:11:13 PDT 
Comment on attachment 133770 [details]
Patch

Seems correct :-)
Comment 3 WebKit Review Bot 2012-03-26 04:57:09 PDT 
Comment on attachment 133770 [details]
Patch

Clearing flags on attachment: 133770

Committed r112077: <http://trac.webkit.org/changeset/112077>
Comment 4 WebKit Review Bot 2012-03-26 04:57:13 PDT 
All reviewed patches have been landed.  Closing bug.