Bug 82182 – Revert linesBoundingBox to integers

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Levi Weintraub]

Moving linesBoundingBox back to integers. We don't pixel snap values from the inline box tree, we enclose them. Keeping linesBoundingBox as integers doesn't change its accuracy, and prevents misuse.

[Levi Weintraub]

Created attachment 133763 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 133763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133763&action=review

> Source/WebCore/ChangeLog:12
> +        LayoutRects are intended to be pixel snapped to determine the ultimate screen
> +        coordinates, but the Inline Box tree is laid out using floats, and pixel snapping
> +        the resulting box from linesBoundingBox would produce a potentially incorrect
> +        rectangle. Keeping this using enclosingIntRect retains the previous accuracy and
> +        prevents misuse.

Clearly you've learned a lot as youv'e gone.  I hope that we've documented this learning for others.  To help make it obvious where LayoutPoint vs. IntPoitn vs. FloatPoint should be used.  It's still not always 100% obvious to me. :(

[Levi Weintraub]

Comment on attachment 133763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133763&action=review

>> Source/WebCore/ChangeLog:12
>> +        prevents misuse.
> 
> Clearly you've learned a lot as youv'e gone.  I hope that we've documented this learning for others.  To help make it obvious where LayoutPoint vs. IntPoitn vs. FloatPoint should be used.  It's still not always 100% obvious to me. :(

Looks like I've got a few things to clear up on the Wiki. I'll give it some more love today. I appreciate the feedback.

[WebKit Review Bot]

Comment on attachment 133763 [details]
Patch

Clearing flags on attachment: 133763

Committed r112237: <http://trac.webkit.org/changeset/112237>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.