Bug 82178 - [Qt]WK2] TextureMapperShaderManager should query the program map before creating new shader program instances.
Summary: [Qt]WK2] TextureMapperShaderManager should query the program map before creat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zeno Albisser
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-26 02:16 PDT by Zeno Albisser
Modified: 2012-03-26 04:18 PDT (History)
1 user (show)

See Also:

Attachments
patch for review. (1.62 KB, patch)
2012-03-26 03:15 PDT, Zeno Albisser 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Albisser 2012-03-26 02:16:57 PDT 
This bug was introduced by r111986 and the subsequent compile fix r111992.

ThextureMapperShaderManager has a map that holds references to all shader programs.
If this map does not contain a shader program of the requested type,
a new shader program should be created and a reference to it will be stored in the map.
If the requested type exists in the map already, a reference to the existing instance shall be returned.

See also: https://bugs.webkit.org/show_bug.cgi?id=82049
Comment 1 Zeno Albisser 2012-03-26 03:15:54 PDT 
Created attachment 133761 [details]
patch for review.
Comment 2 Zeno Albisser 2012-03-26 04:17:53 PDT 
Comment on attachment 133761 [details]
patch for review.

Clearing flags on attachment: 133761

Committed r112075: <http://trac.webkit.org/changeset/112075>
Comment 3 Zeno Albisser 2012-03-26 04:18:01 PDT 
All reviewed patches have been landed.  Closing bug.