Bug 82171 – [chromium] Route willBeginFrame from compositor to WebWidget

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Nat Duca]

[chromium] Route willBeginFrame from compositor to WebWidget

[Nat Duca]

Created attachment 133733 [details]
Patch

[Nat Duca]

Blocks an Aura pdf bug. :( So, rushing.

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Attachment 133733 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Fisher (:fishd, Google)]

Comment on attachment 133733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133733&action=review

> Source/Platform/chromium/public/WebLayerTreeViewClient.h:38
> +    // beginning. This call will be followed by updateAnimations and then layout, which should

half-awake-nit: use similar widths for each row of the comment block?  (same below)

[Darin Fisher (:fishd, Google)]

Comment on attachment 133733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133733&action=review

> Source/WebKit/chromium/public/WebWidgetClient.h:69
> +    // beginning. This call will be followed by updateAnimations and then layout, which should

nit: is it "updateAnimations" or just "animate"?  you are referring to methods
on WebWidget, right?

[Nat Duca]

Comment on attachment 133733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133733&action=review

>> Source/WebKit/chromium/public/WebWidgetClient.h:69
>> +    // beginning. This call will be followed by updateAnimations and then layout, which should
> 
> nit: is it "updateAnimations" or just "animate"?  you are referring to methods
> on WebWidget, right?

Yeah, none of this applies to the webwidget interface. Pruned it to just the comment about flow control. This all moves to our newfangled WebRenderSurface when we grow one.

[Nat Duca]

Created attachment 133738 [details]
Patch for landing

[Nat Duca]

Committed r112059: <http://trac.webkit.org/changeset/112059>