Bug 82171 - [chromium] Route willBeginFrame from compositor to WebWidget
Summary: [chromium] Route willBeginFrame from compositor to WebWidget
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nat Duca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-25 23:31 PDT by Nat Duca
Modified: 2012-03-26 01:03 PDT (History)
8 users (show)

See Also:

Attachments
Patch (10.39 KB, patch)
2012-03-25 23:31 PDT, Nat Duca 		no flags Details | Formatted Diff | Diff
Patch for landing (10.27 KB, patch)
2012-03-25 23:58 PDT, Nat Duca 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nat Duca 2012-03-25 23:31:18 PDT 
[chromium] Route willBeginFrame from compositor to WebWidget
Comment 1 Nat Duca 2012-03-25 23:31:33 PDT 
Created attachment 133733 [details]
Patch
Comment 2 Nat Duca 2012-03-25 23:32:10 PDT 
Blocks an Aura pdf bug. :( So, rushing.
Comment 3 WebKit Review Bot 2012-03-25 23:33:19 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 WebKit Review Bot 2012-03-25 23:33:40 PDT 
Attachment 133733 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Darin Fisher (:fishd, Google) 2012-03-25 23:36:42 PDT 
Comment on attachment 133733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133733&action=review

> Source/Platform/chromium/public/WebLayerTreeViewClient.h:38
> +    // beginning. This call will be followed by updateAnimations and then layout, which should

half-awake-nit: use similar widths for each row of the comment block?  (same below)
Comment 6 Darin Fisher (:fishd, Google) 2012-03-25 23:38:27 PDT 
Comment on attachment 133733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133733&action=review

> Source/WebKit/chromium/public/WebWidgetClient.h:69
> +    // beginning. This call will be followed by updateAnimations and then layout, which should

nit: is it "updateAnimations" or just "animate"?  you are referring to methods
on WebWidget, right?
Comment 7 Nat Duca 2012-03-25 23:43:15 PDT 
Comment on attachment 133733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133733&action=review

>> Source/WebKit/chromium/public/WebWidgetClient.h:69
>> +    // beginning. This call will be followed by updateAnimations and then layout, which should
> 
> nit: is it "updateAnimations" or just "animate"?  you are referring to methods
> on WebWidget, right?

Yeah, none of this applies to the webwidget interface. Pruned it to just the comment about flow control. This all moves to our newfangled WebRenderSurface when we grow one.
Comment 8 Nat Duca 2012-03-25 23:58:15 PDT 
Created attachment 133738 [details]
Patch for landing
Comment 9 Nat Duca 2012-03-26 01:02:57 PDT 
Committed r112059: <http://trac.webkit.org/changeset/112059>