Bug 82158 – add a Tree abstraction to test-webkitpy to better encapsulate things

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

add a Tree abstraction to test-webkitpy to better encapsulate things

[Dirk Pranke]

Created attachment 133712 [details]
Patch

[Dirk Pranke]

Created attachment 133713 [details]
fix typos

[Adam Barth]

Comment on attachment 133713 [details]
fix typos

View in context: https://bugs.webkit.org/attachment.cgi?id=133713&action=review

> Tools/Scripts/webkitpy/test/main.py:238
> +class _Tree(object):

Do you mean a DirectoryTree?  "Tree" is a very broad name.  This code seems very specific to Python packages.

[Dirk Pranke]

Comment on attachment 133713 [details]
fix typos

View in context: https://bugs.webkit.org/attachment.cgi?id=133713&action=review

>> Tools/Scripts/webkitpy/test/main.py:238
>> +class _Tree(object):
> 
> Do you mean a DirectoryTree?  "Tree" is a very broad name.  This code seems very specific to Python packages.

Yes, it refers to directory trees and is intended to by very python-specific. DirectoryTree is a fine name; other suggestions welcome.

[Adam Barth]

Comment on attachment 133713 [details]
fix typos

I'd rename _Tree to something more specific (and maybe put it at the top of the file?).  There's an argument that says we should put the new class in its own module, which would have the benefit of making test-webkitpy smaller.  If we did that we, we'd probably want to use filesystem rather than os.path.  I think it's a question of how far you'd like to shave this yak.

[Dirk Pranke]

(In reply to comment #5)
> (From update of attachment 133713 [details])
> I'd rename _Tree to something more specific (and maybe put it at the top of the file?).  There's an argument that says we should put the new class in its own module, which would have the benefit of making test-webkitpy smaller.  If we did that we, we'd probably want to use filesystem rather than os.path.  I think it's a question of how far you'd like to shave this yak.

Okay, I will rename and move it. 

I don't see much advantage to putting it in a different file, since I don't think anyone else will want to use it, and main.py isn't very big as it is.

Thanks for the review!

[Dirk Pranke]

Created attachment 133899 [details]
rename _Tree to TestDirectoryTree

[Dirk Pranke]

Committed r112150: <http://trac.webkit.org/changeset/112150>